[WIP] command/jsonprovider: export providers schemas to json #20446
Conversation
|
I'm going to work on the bulk of the documentation in a separate PR. |
command/jsonprovider/block.go
Outdated
| case "NestingMap": | ||
| ret.NestingMode = "map" | ||
| default: | ||
| // unpossible. |
There was a problem hiding this comment.
Maybe move the statement from "nestingModeInvalid" down here and remove that case? I think it being literally nestingModeInvalid and it being some value that isn't in the enum at all are... both invalid, really.
command/jsonprovider/block.go
Outdated
| MaxItems: uint64(nestedBlock.MaxItems), | ||
| } | ||
|
|
||
| switch nestedBlock.Nesting.String() { |
There was a problem hiding this comment.
I was surprised to see the .String() call here vs. switching directly on the nestedBlock.Nesting value. Could you add a comment explaining it?
There was a problem hiding this comment.
I'll just drop the .String() and check the nested mode directly - I had doubts when I wrote that but forgot to follow up.
At this point, json output is the only option for the `terraform providers schema` command. To maintain consistency with other terraform commands, and with future enhancements in mind, this should be a requireed flag.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
TODO: