Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 'load_balancers.*' to pass resource_aws_autoscaling_group_validation #207

Merged
merged 1 commit into from
Aug 20, 2014
Merged

Allow 'load_balancers.*' to pass resource_aws_autoscaling_group_validation #207

merged 1 commit into from
Aug 20, 2014

Conversation

ianatha
Copy link

@ianatha ianatha commented Aug 20, 2014

Fixes #206

When the load_balancers arguments is used in an aws_autoscaling_group instance, one gets:

There are warnings and/or errors related to your configuration. Please
fix these before continuing.

Errors:

  * 'aws_autoscaling_group.ingress_nodes' error: Unknown configuration: load_balancers.#
  * 'aws_autoscaling_group.ingress_nodes' error: Unknown configuration: load_balancers.0

No testing of any sort :(

@pearkes
Copy link
Contributor

pearkes commented Aug 20, 2014

Ah, yes. It looks like we missed adding that as a permitted key. I'm going to merge this and add documentation and tests afterwards. I'll cc you, thanks!

pearkes added a commit that referenced this pull request Aug 20, 2014
Allow 'load_balancers.*' to pass resource_aws_autoscaling_group_validation
@pearkes pearkes merged commit 1de0c5e into hashicorp:master Aug 20, 2014
@ianatha
Copy link
Author

ianatha commented Aug 20, 2014

If you give me a hint on your testing strategy I wouldn't mind doing these
things as part of this pull merge.

I had some trouble with the acceptance tests for the AWS provider.
On Aug 20, 2014 10:31 AM, "Jack Pearkes" notifications@github.com wrote:

Ah, yes. It looks like we missed adding that as a permitted key. I'm going
to merge this and add documentation and tests afterwards. I'll cc you,
thanks!


Reply to this email directly or view it on GitHub
#207 (comment).

@ghost ghost locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_autoscaling_group doesn't permit load_balancers.*
2 participants