Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching the healthcheck shouldn't cause a refresh of the resource #2147

Merged
merged 2 commits into from
May 30, 2015
Merged

Switching the healthcheck shouldn't cause a refresh of the resource #2147

merged 2 commits into from
May 30, 2015

Conversation

mzupan
Copy link
Contributor

@mzupan mzupan commented May 29, 2015

Switching the healthcheck from elb->ec2 or ec2->elb shouldn't cause the ASG to re-create itself

You can do this operation in the AWS console

Switching the healthcheck from elb->ec2 or ec2->elb shouldn't cause the ASG to re-create itself
@phinze
Copy link
Contributor

phinze commented May 29, 2015

Unfortunately we can't just flip ForceNew to false here - we need to also handle the attribute change in the Update method. Want to follow the pattern for other attributes in Update and give it a shot?

@mzupan
Copy link
Contributor Author

mzupan commented May 29, 2015

@phinze yep my fault.. I'll update the PR shortly

@mzupan
Copy link
Contributor Author

mzupan commented May 30, 2015

@phinze updated the PR

aws_autoscaling_group.mc: Modifying...
  health_check_type: "ELB" => "EC2"
aws_autoscaling_group.mc: Modifications complete

You need to pass in the grace period if you change the type. So that's why that gets included.

@phinze
Copy link
Contributor

phinze commented May 30, 2015

Nice - thanks! LGTM

phinze added a commit that referenced this pull request May 30, 2015
Switching the healthcheck shouldn't cause a refresh of the resource
@phinze phinze merged commit 060e888 into hashicorp:master May 30, 2015
@ghost
Copy link

ghost commented May 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants