provider/aws elasticache parameter group

[SamClinckspoor]

Implements aws_elasticache_parameter_group

This almost a 1/1 copy of aws_db_parameter_group

vagrant@vagrant:/opt/gopath/src/github.com/hashicorp/terraform$ make test TEST=./builtin/providers/aws
go generate ./...
TF_ACC= go test ./builtin/providers/aws  -timeout=30s -parallel=4
ok      github.com/hashicorp/terraform/builtin/providers/aws    0.032s
make[1]: Entering directory `/opt/gopath/src/github.com/hashicorp/terraform'
go tool vet -asmdecl -atomic -bool -buildtags -copylocks -methods -nilfunc -printf -rangeloops -shift -structtags -unsafeptr .
make[1]: Leaving directory `/opt/gopath/src/github.com/hashicorp/terraform'


vagrant@vagrant:/opt/gopath/src/github.com/hashicorp/terraform$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=ElasticacheParameterGroup' 2>/dev/null
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=ElasticacheParameterGroup -timeout 90m
=== RUN TestAccAWSElasticacheParameterGroup_basic
--- PASS: TestAccAWSElasticacheParameterGroup_basic (9.21s)
=== RUN TestAccAWSElasticacheParameterGroupOnly
--- PASS: TestAccAWSElasticacheParameterGroupOnly (4.61s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    13.846s

[catsby]

if ok here, but not Code() != "CacheParameterGroupNotFoundFault", we fall through to return d, "destroyed", nil , yeah?

We should probably re-write this that if ok do the Code() check, otherwise return return d, "error", err

[catsby]

1 nitpick, otherwise 👍

[SamClinckspoor]

@catsby added your suggestion.

[catsby]

LGTM, I took it for a spin before hand so I'm going to go ahead and merge, thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.