Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: github.com/aws/aws-sdk-go@v1.30.12 [v0.12] #24744

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 22, 2020

v0.12 branch PR
Reference: #24741

Changes:

NOTES:

* backend/s3: Region validation now automatically supports the new `af-south-1` (Africa (Cape Town)) region. For AWS operations to work in the new region, the region must be explicitly enabled as outlined in the [AWS Documentation](https://docs.aws.amazon.com/general/latest/gr/rande-manage.html#rande-manage-enable). When the region is not enabled, the Terraform S3 Backend will return errors during credential validation (e.g. `error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid`).

ENHANCEMENTS:

* backend/s3: Support automatic region validation for `af-south-1`

Updated via:

$ go get github.com/aws/aws-sdk-go@v1.30.12
$ go mod tidy
$ go mod vendor

Output from acceptance testing:

$ TF_ACC=1 go test -v ./backend/remote-state/s3 | grep '^--- '
--- PASS: TestBackend_impl (0.00s)
--- PASS: TestBackendConfig (1.78s)
--- PASS: TestBackendConfig_invalidKey (0.00s)
--- PASS: TestBackendConfig_invalidSSECustomerKeyLength (0.00s)
--- PASS: TestBackendConfig_invalidSSECustomerKeyEncoding (0.00s)
--- PASS: TestBackendConfig_conflictingEncryptionSchema (0.00s)
--- PASS: TestBackend (16.08s)
--- PASS: TestBackendLocked (23.47s)
--- PASS: TestBackendSSECustomerKey (15.35s)
--- PASS: TestBackendExtraPaths (11.74s)
--- PASS: TestBackendPrefixInWorkspace (5.68s)
--- PASS: TestKeyEnv (43.35s)
--- PASS: TestRemoteClient_impl (0.00s)
--- PASS: TestRemoteClient (6.16s)
--- PASS: TestRemoteClientLocks (13.90s)
--- PASS: TestForceUnlock (17.03s)
--- PASS: TestRemoteClient_clientMD5 (14.93s)
--- PASS: TestRemoteClient_stateChecksum (21.08s)

@mildwonkey
Copy link
Contributor

#24759 will enable circleci on this branch so we can run the rest of the test suite.

bflad added a commit that referenced this pull request Apr 24, 2020
@mildwonkey mildwonkey self-assigned this Apr 24, 2020
Updated via:

```console
$ go get github.com/aws/aws-sdk-go@v1.30.12
$ go mod tidy
$ go mod vendor
```

Output from acceptance testing:

```console
$ TF_ACC=1 go test -v ./backend/remote-state/s3 | grep '^--- '
--- PASS: TestBackend_impl (0.00s)
--- PASS: TestBackendConfig (1.78s)
--- PASS: TestBackendConfig_invalidKey (0.00s)
--- PASS: TestBackendConfig_invalidSSECustomerKeyLength (0.00s)
--- PASS: TestBackendConfig_invalidSSECustomerKeyEncoding (0.00s)
--- PASS: TestBackendConfig_conflictingEncryptionSchema (0.00s)
--- PASS: TestBackend (16.08s)
--- PASS: TestBackendLocked (23.47s)
--- PASS: TestBackendSSECustomerKey (15.35s)
--- PASS: TestBackendExtraPaths (11.74s)
--- PASS: TestBackendPrefixInWorkspace (5.68s)
--- PASS: TestKeyEnv (43.35s)
--- PASS: TestRemoteClient_impl (0.00s)
--- PASS: TestRemoteClient (6.16s)
--- PASS: TestRemoteClientLocks (13.90s)
--- PASS: TestForceUnlock (17.03s)
--- PASS: TestRemoteClient_clientMD5 (14.93s)
--- PASS: TestRemoteClient_stateChecksum (21.08s)
```
@bflad bflad force-pushed the v-aws-sdk-go-1.30.12-v0.12 branch from d726475 to d051f41 Compare April 27, 2020 18:58
@bflad
Copy link
Contributor Author

bflad commented Apr 27, 2020

Rebased as requested. 👍

@mildwonkey
Copy link
Contributor

Look at those fancy tests 😍 thank you so much @bflad!

Copy link
Contributor

@mildwonkey mildwonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have immediate plans for another 0.12* release, but if we do this will be included!

@bflad bflad merged commit 60632cd into v0.12 Apr 28, 2020
@bflad bflad deleted the v-aws-sdk-go-1.30.12-v0.12 branch April 28, 2020 01:49
bflad added a commit that referenced this pull request Apr 28, 2020
@ghost
Copy link

ghost commented May 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants