This adds the source_dest_check attribute to the aws_network_interfac…

[jszwedko]

…e resource

Addresses #2407

[stack72]

This is the same as #2721 but I am happy to close mine as you have added tests :)

[stack72]

@catsby / @phinze / @radeksimko any chance someone could have a look at this - it's a blocker for running a better HA solution for NAT boxes (using ENI and EIPs)

thanks :)

[stack72]

bump

[catsby]

We need to add Default: true, here, or otherwise any user who omits the source_dest_check attribute will send a false value to the API

[catsby]

which also means that we need to remove the Computed part here (can't have both computed and default)

[jszwedko]

Oops! Missed that when I removed the guarding conditional.

[catsby]

A few nitpicks but overall looks good! Let's see about the updates and making sure all the Acceptance tests pass, then we'll be good 👍

[jszwedko]

@catsby swapped Computed for Default and made sure all of the acceptance tests for AWS ENI pass. Also squashed it down to keep the commit history cleaner.

Let me know if any more changes need to be made, thanks for looking at this!

[catsby]

Looking great now, thanks! Pulling this in

[jszwedko]

Awesome, thanks! 🎺

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.