Reuse installed target dir providers in init #27582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pselle
force-pushed
the
pselle/reuse_targetdir_providers
branch
from
08068e0 to
8ceb071
Compare
Codecov Report
|
pselle
force-pushed
the
pselle/reuse_targetdir_providers
branch
2 times, most recently
from
ae5db28 to
cf0fcd7
Compare
In init, we can check to see if the target dir already has the provider we are seeking and skip further querying/installing of that provider.
pselle
force-pushed
the
pselle/reuse_targetdir_providers
branch
from
cf0fcd7 to
aedca59
Compare
pselle
added
the
0.14-backport
mildwonkey
approved these changes
Jan 25, 2021
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In init, we can check to see if the target dir already has the provider we are seeking and skip further querying/installing of that provider.
This will help address concerns users are having where they've previously installed a provider (ex. that is in their
.terraformdirectory after install) and subsequent installs keep re-fetching the package. While we've been telling users this installation is expected behavior, I think we can make a nicer flow by making things faster by re-using that same provider if it's already installed.Closes #27534