use official Go client for DigitalOcean provider

[aybabtme]

This PR replaces usage of the github.com/pearkes/digitalocean package with the official Go client at github.com/digitalocean/godo.

[aybabtme]

i've removed this test because it does the same thing as the one above it (line 181):

if findIPv4AddrByType(droplet, "private") == "" {
    return fmt.Errorf("No ipv4 private: %s", findIPv4AddrByType(droplet, "private"))
}

[aybabtme]

@radeksimko can I get some 👀 on this?

[ajlanghorn]

Use of godo = 👍, especially since this hopefully gets new DO features in to Terraform quickly after they're released.

[bryanl]

@ajlanghorn Yes, that's the goal.

[apparentlymart]

This looks awesome! Given that there is a release coming shortly I'm personally leaning towards holding off on this until after the release is cut since it's quite a broad change that might have unintended consequences for Terraform's DigitalOcean support. By merging it just after the release there will be some time for it to settle in on master before it gets included in the next release.

Does that seem reasonable or is there a driver here to merge this sooner rather than later?

[aybabtme]

@apparentlymart is there a timeline for the release? One feature I'd like to add should come around by the end of the month. We can always add support for that feature a bit later after the new feature release, although I'd like to add it at the same time =].

[apparentlymart]

@aybabtme I'm not on Hashicorp staff so the release process is not visible to me but I've seen @phinze and @catsby talk about doing a release within the next week or so. Since they're the ones driving the release train I'm going to let them make the call about whether to merge this in.

[catsby]

Hello friends –

Thanks for the contribution here!
Like @apparentlymart mentioned, we'd like to hold off on merging this until after the upcoming release, just to be safe, for all the reasons mentioned.

Thanks again, we're looking forward to more DO features coming after this merge 😄

After the release I'll swing back around and merge this.

[aybabtme]

awesome! thanks @catsby and @apparentlymart

[phinze]

Alright the release is out so we are ready to merge this - thanks for your work on this @aybabtme!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.