Allow unknown error_message values during validate walk
#35537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When evaluating variable validation, we may have valid error_message values which are unknown due to input other referenced input variables always being unknown during the validate walk. In the rare case where the variable validation is known but the error_message is not, we need to be able to proceed to the plan phase in order to check the validation more thoroughly.
liamcervante
approved these changes
Aug 6, 2024
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When evaluating variable validation, we may have valid
error_messagevalues which are unknown due to all other referenced input variables being unknown during the validate walk. In the rare case where the variable validation is known but theerror_messageis not, we need to be able to proceed to the plan phase in order to check the validation more thoroughly.Fixes #35397
Target Release
1.10
Draft CHANGELOG entry
BUG FIXES
error_messagevalues to pass the core validate step, so variable validation can be completed later during plan.