-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vsphere_virtual_machine: Network interfaces #3652
Conversation
before added new one. Fixes hashicorp#3559 and hashicorp#3560
customizations and add devices in the new server. When finished PowerOn
Hi, I've just added a few changes in this PR. Now template didn't change. The process of the server is the following:
This has a new dependency in govmomi, and this PR need to be accepted. P.S: I'll update the godeps when the govmomi get merged. Cheers |
@eloycoto you sign the CLA for govmomi? See their comments on your PR. |
Hi, @chrislovecnm: Yep, is merged now. vmware/govmomi#365 @radeksimko: This should be ok, I've just check that no godeps or glide for the dependencies. So this PR can be merged if you want ;-) Thanks. |
Hi @eloycoto - thanks for this! A few questions:
|
@eloycoto I tried to run the acceptance tests in my environment. The test has passed in case of a template containing some network devices. Thank you! |
@tkak that is great to hear! Does that mean you can add a test covering the new behavior if we merge this as is? |
@phinze can we get this merged? |
Sounds good - it would still be nice to get a covering acceptance test for the new behavior. But we can merge as-is push that to a separate task. |
Vsphere_virtual_machine: Network interfaces
Hey @chrislovecnm! Sorry, I was on vacation. I'll send a new PR this week with new test. Cheers |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Hi,
This PR fix #3559 and #3560, when a template is cloned we deleted all the interfaces so the createNetworkInterfaces will work correctly.
Regards.