provider/aws: AWS Redshift #3862

stack72 · 2015-11-11T20:57:59Z

The first version of this PR does not support tags. The following will be supported:

Redshift Cluster

schema
CRUD functionality
acceptance tests
documentation

Redshift Subnet Groups

schema
CRUD functionality
acceptance tests
documentation

make testacc TEST=./builtin/providers/aws TESTARGS='-run=RedshiftSubnetGroup_' 2>~/tf.log
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=RedshiftSubnetGroup_ -timeout 90m
=== RUN   TestAccAWSRedshiftSubnetGroup_basic
--- PASS: TestAccAWSRedshiftSubnetGroup_basic (19.78s)
=== RUN   TestAccAWSRedshiftSubnetGroup_updateSubnetIds
--- PASS: TestAccAWSRedshiftSubnetGroup_updateSubnetIds (30.73s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    50.532s

Redshift Parameter Groups

schema
CRUD functionality
acceptance tests
documentation

make testacc TEST=./builtin/providers/aws TESTARGS='-run=RedshiftParameterGroup_with' 2>~/tf.log
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=RedshiftParameterGroup_with -timeout 90m
=== RUN   TestAccAWSRedshiftParameterGroup_withParameters
--- PASS: TestAccAWSRedshiftParameterGroup_withParameters (9.41s)
=== RUN   TestAccAWSRedshiftParameterGroup_withoutParameters
--- PASS: TestAccAWSRedshiftParameterGroup_withoutParameters (8.86s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    18.283s

Please note - there is no ability to apply parameter modifications immediately. Redshift needs a reboot to handle this

Redshift Security Groups

schema
CRUD functionality
acceptance tests
documentation

make testacc TEST=./builtin/providers/aws TESTARGS='-run=RedshiftSecurityGroup_ingress' 2>~/tf.log
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=RedshiftSecurityGroup_ingress -timeout 90m
=== RUN   TestAccAWSRedshiftSecurityGroup_ingressCidr
--- PASS: TestAccAWSRedshiftSecurityGroup_ingressCidr (7.15s)
=== RUN   TestAccAWSRedshiftSecurityGroup_ingressSecurityGroup
--- PASS: TestAccAWSRedshiftSecurityGroup_ingressSecurityGroup (12.21s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    19.384s

This is going to be a longer running PR as there is a lot of functionality in place. I may break this down into smaller PRs to make it easier to review - that can happen later

radeksimko · 2015-11-16T21:53:46Z

builtin/providers/aws/structure_test.go

@@ -426,7 +427,36 @@ func TestExpandParameters(t *testing.T) {
 	}
 }

+<<<<<<< HEAD


Some unresolved conflicts here I think?

stack72 · 2015-11-26T10:07:56Z

@radeksimko apologies for this - this has now been rectified

jonbca · 2015-12-20T20:15:59Z

Just wondering if this is still "alive," or you need a hand?

Finalising the schema and acceptance tests for the Redshift Security Group's

Creation of the schema, CRUD and acceptance tests for Redshift Parameter Group

Changed the aws_redshift_security_group and aws_redshift_parameter_group to remove the tags from the schema. Tags are a little bit more complicated than originally though - I will revisit this later Then added the schema, CRUD functionality and basic acceptance tests for aws_redshift_subnet_group Adding an acceptance test for the Update of subnet_ids in AWS Redshift Subnet Group

also removed the notion of tags from the redshift security group and parameter group documentation until that has been implemented Redshift Cluster CRUD and acceptance tests Removing the Acceptance test for the Cluster Updates. You cannot delete a cluster immediately after performing an operation on it. We would need to add a lot of retry logic to the system to get this test to work Adding some schema validation for RedShift cluster Adding the last of the pieces of a first draft of the Redshift work - this is the documentation

stack72 · 2015-12-20T20:27:42Z

@jonbca this will be merged very soon

catsby · 2015-12-21T14:27:10Z

@stack72 all ready for review then?

stack72 · 2015-12-21T17:20:56Z

@catsby I believe that @jen20 had already started reviewing this but he can confirm

catsby · 2016-01-13T22:02:40Z

builtin/providers/aws/resource_aws_redshift_cluster.go

+		if awsErr, ok := err.(awserr.Error); ok {
+			if "ClusterNotFound" == awsErr.Code() {
+				d.SetId("")
+				log.Printf("[DEBUG] Redshift Cluster (%s) not found", d.Id())


need this log statement before you call d.SetId(""), otherwise you'll log an "" 😄

catsby · 2016-01-13T22:52:41Z

Wow, a lot of work done here, very nice @stack72!

I did a review and things look good. The tests pass, pending a few tweaks (I'll link the commit in a follow up).

Going to pull this in, thanks!

provider/aws: AWS Redshift

catsby · 2016-01-13T22:58:29Z

Touchups: 8181a4e

* master: (721 commits) Update CHANGELOG.md Update CHANGELOG.md Update CHANGELOG.md Handle external state changes for Packet resources gracefully. provider/aws: Add profile to provider config Bug fixes for aws_autoscaling_schedule resource Update CHANGELOG.md provider/docker: Fix flaky integration tests Update CHANGELOG.md minor clean ups after #3862 Update CHANGELOG.md Update CHANGELOG.md Update CHANGELOG.md provider/google: Content field for bucket objects provider/google: SQL user resource, documentation & tests Update CHANGELOG.md Update CHANGELOG.md Update CHANGELOG.md Update CHANGELOG.md move the 'color' assignment ...

…h_compute_environment-sweeper resource/aws_batch_*: Add test sweepers

ghost · 2020-04-28T02:32:11Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

jen20 added enhancement provider/aws labels Nov 11, 2015

stack72 force-pushed the aws-redshift branch from eb47e52 to dce61d8 Compare November 11, 2015 23:46

apparentlymart mentioned this pull request Nov 12, 2015

Support AWS Redshift #3753

Closed

stack72 force-pushed the aws-redshift branch from 80a5816 to 92fe91b Compare November 13, 2015 22:26

stack72 changed the title ~~[WIP] provider/aws: AWS Redshift~~ provider/aws: AWS Redshift Nov 13, 2015

radeksimko reviewed Nov 16, 2015
View reviewed changes

stack72 force-pushed the aws-redshift branch from 92fe91b to c23b5f6 Compare November 26, 2015 10:06

stack72 force-pushed the aws-redshift branch 2 times, most recently from 2dd2a64 to 1493aaf Compare November 26, 2015 10:41

stack72 added 4 commits December 20, 2015 20:19

Initial creation of the work for AWS RedShift Support

85afc7d

Finalising the schema and acceptance tests for the Redshift Security Group's

Adding the documentation for the Redshift security groups

249e7df

Creation of the schema, CRUD and acceptance tests for Redshift Parameter Group

stack72 force-pushed the aws-redshift branch from 1493aaf to bf03752 Compare December 20, 2015 20:20

stack72 closed this Dec 20, 2015

stack72 reopened this Dec 20, 2015

catsby reviewed Jan 13, 2016
View reviewed changes

catsby added a commit that referenced this pull request Jan 13, 2016

Merge pull request #3862 from stack72/aws-redshift

7f6624e

provider/aws: AWS Redshift

catsby merged commit 7f6624e into hashicorp:master Jan 13, 2016

catsby added a commit that referenced this pull request Jan 13, 2016

minor clean ups after #3862

8181a4e

omeid pushed a commit to omeid/terraform that referenced this pull request Mar 30, 2018

Merge pull request hashicorp#3862 from terraform-providers/t-aws_batc…

680afc8

…h_compute_environment-sweeper resource/aws_batch_*: Add test sweepers

ghost locked and limited conversation to collaborators Apr 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

provider/aws: AWS Redshift #3862

provider/aws: AWS Redshift #3862

stack72 commented Nov 11, 2015

radeksimko Nov 16, 2015

stack72 commented Nov 26, 2015

jonbca commented Dec 20, 2015

stack72 commented Dec 20, 2015

catsby commented Dec 21, 2015

stack72 commented Dec 21, 2015

catsby Jan 13, 2016

catsby commented Jan 13, 2016

catsby commented Jan 13, 2016

ghost commented Apr 28, 2020

provider/aws: AWS Redshift #3862

provider/aws: AWS Redshift #3862

Conversation

stack72 commented Nov 11, 2015

Redshift Cluster

Redshift Subnet Groups

Redshift Parameter Groups

Redshift Security Groups

radeksimko Nov 16, 2015

Choose a reason for hiding this comment

stack72 commented Nov 26, 2015

jonbca commented Dec 20, 2015

stack72 commented Dec 20, 2015

catsby commented Dec 21, 2015

stack72 commented Dec 21, 2015

catsby Jan 13, 2016

Choose a reason for hiding this comment

catsby commented Jan 13, 2016

catsby commented Jan 13, 2016

ghost commented Apr 28, 2020