-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/aws: DynamoDB Table StreamSpecifications #4208
Conversation
@phinze this is as per your open issue :) |
"stream_view_type": &schema.Schema{ | ||
Type: schema.TypeString, | ||
Optional: true, | ||
Computed: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a ValidateFunc here so we can catch user typos at plan time? Or do you think the set of valid attributes will change frequently enough that we should avoid trying to duplicate the correct list of values here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are only 4 values so I can certainly add a small func that will check it's the correct values. It wouldn't take me long if you feel it would be useful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems worth doing then! We're doing everything we can to push more useful feedback to plan-time. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phinze ok, this is currently building in travis and then it's ready for you again :)
Looking good - thanks! 😄 |
provider/aws: DynamoDB Table StreamSpecifications
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Adding support for AWS DynamoDB Table for StreamSpecifications as per #4188