Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: DynamoDB Table StreamSpecifications #4208

Merged
merged 2 commits into from
Dec 9, 2015

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Dec 8, 2015

Adding support for AWS DynamoDB Table for StreamSpecifications as per #4188

make testacc TEST=./builtin/providers/aws TESTARGS='-run=AWSDynamoDbTable' 2>~/tf.log
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=AWSDynamoDbTable -timeout 90m
=== RUN   TestAccAWSDynamoDbTable
-- PASS: TestAccAWSDynamoDbTable (290.82s)
=== RUN   TestAccAWSDynamoDbTable_streamSpecification
--- PASS: TestAccAWSDynamoDbTable_streamSpecification (10.02s)
PASS

@stack72
Copy link
Contributor Author

stack72 commented Dec 8, 2015

@phinze this is as per your open issue :)

"stream_view_type": &schema.Schema{
Type: schema.TypeString,
Optional: true,
Computed: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a ValidateFunc here so we can catch user typos at plan time? Or do you think the set of valid attributes will change frequently enough that we should avoid trying to duplicate the correct list of values here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are only 4 values so I can certainly add a small func that will check it's the correct values. It wouldn't take me long if you feel it would be useful

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems worth doing then! We're doing everything we can to push more useful feedback to plan-time. 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phinze ok, this is currently building in travis and then it's ready for you again :)

@phinze
Copy link
Contributor

phinze commented Dec 9, 2015

Looking good - thanks! 😄

phinze added a commit that referenced this pull request Dec 9, 2015
provider/aws: DynamoDB Table StreamSpecifications
@phinze phinze merged commit 5884323 into hashicorp:master Dec 9, 2015
@stack72 stack72 deleted the aws-dynamodb_streams branch December 9, 2015 10:38
@ghost
Copy link

ghost commented Apr 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants