Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/aws: aws_network_acl_rule #4286

Merged
merged 3 commits into from
Dec 18, 2015
Merged

provider/aws: aws_network_acl_rule #4286

merged 3 commits into from
Dec 18, 2015

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Dec 12, 2015

Scaffolding of the AWS Network ACL Entry resource

  • schema
  • CRUD work
  • Acceptance Tests
  • Documentation

Test Results

TF_LOG=1 make testacc TEST=./builtin/providers/aws TESTARGS='-run=AWSNetworkAclRule' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=AWSNetworkAclRule -timeout 90m
=== RUN   TestAccAWSNetworkAclRule_basic
--- PASS: TestAccAWSNetworkAclRule_basic (10.25s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    10.263s

@stack72 stack72 force-pushed the aws-network-acl-rule branch 5 times, most recently from 7767401 to 91ccdf1 Compare December 13, 2015 17:23
@stack72 stack72 force-pushed the aws-network-acl-rule branch 2 times, most recently from 4f2c933 to 0a9a8ad Compare December 18, 2015 16:57
@stack72 stack72 changed the title [WIP] provider/aws: aws_network_acl_rule provider/aws: aws_network_acl_rule Dec 18, 2015
jen20
jen20 reviewed Dec 18, 2015
View reviewed changes
builtin/providers/aws/resource_aws_network_acl_rule_test.go
}

func testAccCheckAWSNetworkAclRuleExists(n string, networkAcl *ec2.NetworkAcl) resource.TestCheckFunc {
conn := testAccProvider.Meta().(*AWSClient).ec2conn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be inside the function returned, otherwise it will attempt to evaluate when running normal tests as well (and panic as we see in Travis).

@jen20
Copy link
Contributor

jen20 commented Dec 18, 2015

LGTM, with some comments inline!

@jen20 jen20 removed the wip label Dec 18, 2015
@jen20
Copy link
Contributor

jen20 commented Dec 18, 2015

LGTM! Thanks @stack72.

jen20 added a commit that referenced this pull request Dec 18, 2015
@jen20
Merge pull request #4286 from stack72/aws-network-acl-rule
7c1811d 
provider/aws: aws_network_acl_rule
@jen20 jen20 merged commit 7c1811d into hashicorp:master Dec 18, 2015
@stack72 stack72 deleted the aws-network-acl-rule branch December 19, 2015 00:34
@phinze phinze mentioned this pull request Dec 22, 2015
Closed
@ghost
Copy link

ghost commented Apr 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 29, 2020
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement provider/aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stack72 @jen20 @radeksimko