Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/openstack Changing the port resource to mark the ip_address as optional #4850

Merged
merged 1 commit into from
Jan 28, 2016

Conversation

Sheile
Copy link
Contributor

@Sheile Sheile commented Jan 27, 2016

According to API reference of openstack, ip_address attribute of port resource is optional.
http://developer.openstack.org/api-ref-networking-v2.html#createPort

@jtopjian
Copy link
Contributor

Thanks for both PRs 😄

I should have time to look at them in detail within the next day.

@jtopjian
Copy link
Contributor

@Sheile I just opened PR against this branch to clean up a few items. Most notably is the ability to read the IP address that is assigned. Let me know if you have any questions.

@jtopjian
Copy link
Contributor

Oh duh, nevermind. I see that #4851 is exactly the same work I did! Oh well, it was a good exercise :)

I'll merge these in and add the acceptance test I created in another PR.

@jtopjian jtopjian changed the title provider/openstack Changing the port resource to mark the ip_address … provider/openstack Changing the port resource to mark the ip_address as optional Jan 28, 2016
jtopjian added a commit that referenced this pull request Jan 28, 2016
provider/openstack Changing the port resource to mark the ip_address as optional
@jtopjian jtopjian merged commit 5474d75 into hashicorp:master Jan 28, 2016
@Sheile Sheile deleted the f-openstack-optional-ipaddress branch January 29, 2016 07:27
@ghost
Copy link

ghost commented Apr 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants