Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add support for account password policy #5029

Merged
merged 3 commits into from
Feb 26, 2016

Conversation

radeksimko
Copy link
Member

This should allow codifying AWS account-wide password policy.

To do:

  • Initial implementation
  • Documentation
  • Acceptance tests

@phinze phinze changed the title provider/aws: Add support for account password policy [WIP] provider/aws: Add support for account password policy Feb 9, 2016
@phinze phinze removed the wip label Feb 9, 2016
return nil
}

func resourceAwsIamAccountPasswordPolicyUpdate(d *schema.ResourceData, meta interface{}) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to do this. In the schema declaration, we can do this:

Create: resourceAwsIamAccountPasswordPolicyCreate,
Read:   resourceAwsIamAccountPasswordPolicyRead,
Update: resourceAwsIamAccountPasswordPolicyCreate,
Delete: resourceAwsIamAccountPasswordPolicyDelete,

@stack72
Copy link
Contributor

stack72 commented Feb 12, 2016

This one is also ace! If you want, you can merge and I can add acceptance tests as I have some free time today

@radeksimko radeksimko force-pushed the f-aws-iam-pass-policy branch from 3c61abd to 3639ec6 Compare February 25, 2016 19:52
@radeksimko radeksimko force-pushed the f-aws-iam-pass-policy branch from ce9c727 to 39f6eb1 Compare February 26, 2016 11:04
@radeksimko radeksimko changed the title [WIP] provider/aws: Add support for account password policy provider/aws: Add support for account password policy Feb 26, 2016
@radeksimko
Copy link
Member Author

This is now ready for review.

@stack72
Copy link
Contributor

stack72 commented Feb 26, 2016

@radeksimko this looks really good. The only small thing I would say is that we should maybe add a note to the docs saying that only 1 password policy is allowed per AWS account. Apart from that it's 👍

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSIAMAccountPasswordPolicy'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSIAMAccountPasswordPolicy -timeout 120m
=== RUN   TestAccAWSIAMAccountPasswordPolicy_basic
--- PASS: TestAccAWSIAMAccountPasswordPolicy_basic (11.90s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    11.918s

@radeksimko radeksimko force-pushed the f-aws-iam-pass-policy branch from 39f6eb1 to 5b4fcca Compare February 26, 2016 13:29
@radeksimko
Copy link
Member Author

Agreed about the note, I added the following:

screen shot 2016-02-26 at 13 30 26

I will wait for green from Travis, then merge.

@stack72
Copy link
Contributor

stack72 commented Feb 26, 2016

Spot on :)

radeksimko added a commit that referenced this pull request Feb 26, 2016
provider/aws: Add support for account password policy
@radeksimko radeksimko merged commit d60f228 into hashicorp:master Feb 26, 2016
@radeksimko radeksimko deleted the f-aws-iam-pass-policy branch February 26, 2016 13:36
@ghost
Copy link

ghost commented Apr 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants