Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/openstack: Multi Ephemeral Disk Support #5131

Merged
merged 2 commits into from
Feb 27, 2016

Conversation

jtopjian
Copy link
Contributor

This commit adds the ability to create instances with multiple ephemeral (local) disks.

Fixes #4042
Fixes #5098

@afritzler
Copy link

@jtopjian I tested the RP on our OpenStack and it is looking good. I managed to split up a 4TB ephemeral disk into 4 single block devices.

One note though regarding the boot device:

    block_device {
      boot_index = 0
      delete_on_termination = true
      destination_type = "local"
      source_type = "image"
      uuid = "<image uuid>"
    }

Did I get it correct, that the block device (index=0) is mandatory? Because I could not create an instance without it. Also, it would be great to use the image_name instead of the uuid.

@jtopjian
Copy link
Contributor Author

@afritzler Yes, I think boot_index = 0 is required. Good point about image_name instead of uuid. I think I'll work in getting this PR merged and then work on image_name as an enhancement.

@afritzler
Copy link

Btw. one more thing regarding guest_format = "ext4": is this flag actually doing something? I ended up with an unformatted vanilla disk.

@jtopjian
Copy link
Contributor Author

@afritzler To be honest, I'm not sure. I'd have to dig into the actual Nova API code to look. However, guest_format is being passed to the Nova API when nova boot is run on the command line (Check the nodes from #4042), so it might be a good idea to include it from the very start.

Edit: never mind, it's an optional attribute. You can safely omit it. Documentation has been updated. :)

This commit adds the ability to create instances with multiple
ephemeral disks. The ephemeral disks will appear as local block
devices to the instance.
@jtopjian jtopjian force-pushed the openstack-multi-ephemeral branch from b3d7019 to ed9e7de Compare February 27, 2016 04:57
This commit fixes and cleans up instance block_device configuration.

Reverts hashicorp#5354 in that `volume_size` is only required in certain
block_device configuration combinations. Therefore, the actual
attribute must be set to Optional and later checks done.

Doc upates, too.
@jtopjian jtopjian force-pushed the openstack-multi-ephemeral branch from 04b701e to e872c3d Compare February 27, 2016 06:05
jtopjian added a commit that referenced this pull request Feb 27, 2016
provider/openstack: Multi Ephemeral Disk Support
@jtopjian jtopjian merged commit 09c192c into hashicorp:master Feb 27, 2016
@jtopjian jtopjian deleted the openstack-multi-ephemeral branch March 23, 2017 16:08
@ghost
Copy link

ghost commented Apr 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants