Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/aws: aws_elastisearch_domain tags not being set correctly. #5361

Merged
merged 1 commit into from
Feb 29, 2016
Merged

provider/aws: aws_elastisearch_domain tags not being set correctly. #5361

merged 1 commit into from
Feb 29, 2016

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Feb 28, 2016

Fixes #5325. The top level object was used not the tags list within

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSElasticSearchDomain_basic' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSElasticSearchDomain_basic -timeout 120m
=== RUN   TestAccAWSElasticSearchDomain_basic
--- PASS: TestAccAWSElasticSearchDomain_basic (1114.63s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    1114.658s

stack72
stack72 reviewed Feb 28, 2016
View reviewed changes
builtin/providers/aws/resource_aws_elasticsearch_domain_test.go
@@ -149,10 +147,6 @@ func testAccCheckESDomainDestroy(s *terraform.State) error {
const testAccESDomainConfig = `
resource "aws_elasticsearch_domain" "example" {
domain_name = "tf-test-1"

tags {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a FYI, the addition of tags to the basic test actually masked this issue. There is another test in place that checks for tags

@radeksimko radeksimko added the waiting-response An issue/pull request is waiting for a response from the community label Feb 28, 2016
@stack72
provider/aws: aws_elastisearch_domain tags not being set correctly.
7b61567 
The top level object was used not the tags within
@radeksimko radeksimko removed the waiting-response An issue/pull request is waiting for a response from the community label Feb 28, 2016
@radeksimko
Copy link
Member

LGTM. Merge at will.

stack72 added a commit that referenced this pull request Feb 29, 2016
@stack72
Merge pull request #5361 from stack72/b-aws-es-tags
e6f3faf 
provider/aws: `aws_elastisearch_domain` tags not being set correctly.
@stack72 stack72 merged commit e6f3faf into hashicorp:master Feb 29, 2016
@stack72 stack72 deleted the b-aws-es-tags branch February 29, 2016 17:38
@stack72 stack72 mentioned this pull request Feb 29, 2016
Closed
@ghost
Copy link

ghost commented Apr 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug provider/aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ResourceNotFoundException: No tags found for provided resource on "aws_elasticsearch_domain" provider
2 participants
@stack72 @radeksimko