Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add support for OpsWorks Apps #5970

Closed
1 of 3 tasks
u2mejc opened this issue Apr 1, 2016 · 13 comments
Closed
1 of 3 tasks

provider/aws: Add support for OpsWorks Apps #5970

u2mejc opened this issue Apr 1, 2016 · 13 comments

Comments

@u2mejc
Copy link
Contributor

u2mejc commented Apr 1, 2016

Hello, per issue #28, I'm creating a new issue request.

OpsWorks preliminary support was already in the v0.6.x release, but it's missing critical api coverage to make it useful. IMHO ultimate coverage would include: stack, layers, instances and apps creation. This way, Terraform manages the infrastructure, and separately a CI environment can simply use the AWS create-deployment hook when builds pass.

Dependencies:

👍

@janschumann
Copy link
Contributor

Are you already working on OpsWorks Apps? Unfortunately I have missed this issue and started to work on it also. https://github.com/finanzcheck/terraform/tree/opsworks_apps

Want to work on this together?

Hm. Found an open PR on that task: #4419

@u2mejc
Copy link
Contributor Author

u2mejc commented Apr 1, 2016

How in the world did you find that? I must not have broaden my search to include "applications" and with no discussion, I'm sure it wouldn't be high in the results anyways.

@janschumann I'd be happy to work together on this but I guess we should work with the existing PR if it's feature complete. I'll try rebasing it, but I'd like to rename it to aws_opsworks_app, mirroring your branch. I'm not fixated on the resource name, but it eases use (and SEO) when the naming matches the AWS's use and I'm not keen to terraform renaming some functions.

Are you already working on OpsWorks Apps? Unfortunately I have missed this issue and started to work on it also. https://github.com/finanzcheck/terraform/tree/opsworks_apps

Want to work on this together?

Hm. Found an open PR on that task: #4419

@janschumann
Copy link
Contributor

Check. Let me know if you get the rebase work. I gave it a quick try with conflicts in base aws provider sources...

@apparentlymart apparentlymart changed the title aws/provider: Add support for OpsWorks Apps provider/aws: Add support for OpsWorks Apps Apr 1, 2016
@u2mejc
Copy link
Contributor Author

u2mejc commented Apr 2, 2016

@janschumann I pulled down the PR, was able to rebase it (only one line collision was in builtin/providers/aws/provider.go, the list of resources has changed significantly in the last few months). I've posted a patch for @odise in his PR so he can get the cred for his hard work and get the PR to compile against master today. 😄

@janschumann
Copy link
Contributor

I´ll keep working on my own branch. At least for my education :-)

@odise
Copy link
Contributor

odise commented Apr 4, 2016

Guys feel free to work on this PR. I won't continue it as I'm currently working on other topics.

@janschumann
Copy link
Contributor

@odise Ok. Thanks for adding me to your fork!

@janschumann
Copy link
Contributor

@odise @u2mejc #4419 is now squashed and rebased. please let me know if i can do anything to get it merged. i would also like to discuss improvements/enhancements for this resource.

@u2mejc
Copy link
Contributor Author

u2mejc commented Apr 4, 2016

Thx @odise 👍

@u2mejc
Copy link
Contributor Author

u2mejc commented Apr 4, 2016

Awesome work @janschumann Let's talk about enhancements here too.

Hopefully we can get #3459's support meged about the same time too.

@apparentlymart
Copy link
Contributor

#4419 and #3459 are merged now, so I think this issue is resolved... let me know if I missed something else in the comments!

@u2mejc
Copy link
Contributor Author

u2mejc commented Apr 16, 2016

Thank you Martin!!!

@ghost
Copy link

ghost commented Apr 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants