Ignition provider #6189

mcuadros · 2016-04-15T14:39:22Z

This is a WIP version of the ignition provider, the reason behind opening of a WIP feature is just because I am looking for validate the usage of the provider.

Ignition counts with a lot of "resources": disk, partitions, users, groups, networks, unit from systemd, etc. The chance to need to build different ignition configs, reusing "resources", is very high, this is why I am implementing this "resources" as real terraform resources.

A small example of the suggested usage:

resource "ignition_config" "test" {
    users = [
        "${ignition_user.foo.id}",
        "${ignition_user.qux.id}",
    ]
}

resource "ignition_user" "foo" {
    name = "foo"
    password_hash = "foo"
}

resource "ignition_user" "qux" {
    name = "qux"
    password_hash = "qux"
}

The resources are cached by id internally and the ignition_config resource builds the Config object and generates the JSON in the rendered containing the ignition generated file.

New resources:

…ation

jen20 · 2016-04-15T15:52:05Z

Hi @mcuadros! This looks like a great start from a quick scan over the code - we can definitely review more thoroughly once you designate it no longer WIP. In order to help us understand the trajectory, it might be helpful to know what else you plan on adding? Thanks for opening a pull request!

mcuadros · 2016-04-15T15:55:58Z

@jen20 I am planing to give full support. About the method I am using to link the resources... is this ok?

mcuadros · 2016-04-18T22:30:15Z

This provider is completed and documented. /cc @jen20

mcuadros · 2016-04-26T09:11:53Z

@jen20 some news?

mcuadros · 2016-06-09T04:06:57Z

ping @jen20

rdeusser · 2016-07-21T19:46:21Z

It's been a few months now. Any movement on this?

mcuadros · 2016-08-01T22:28:03Z

@jen20 is complete with tests, since months.

adamcstephens · 2017-01-03T02:20:42Z

What's the status of this?

jen20 · 2017-01-03T05:38:26Z

Hi @mcuadros! Sorry for not responding to this sooner, I no longer work full-time on Terraform. An initial scan of this looks good to me. Since it is using the Go library for generating ignition config I think the testing strategy is fine. There are a few predictable conflicts from this having been left for so long, but these are easily resolved from our side. Perhaps @stack72 can pick this up, it looks like a reasonably quick win to merge.

mcuadros · 2017-01-03T07:59:20Z

I just did the rebase, will be good having this merged, since ignition is suggested way to provision CoreOS and cloud-config has being discontinued.

stack72 · 2017-01-03T08:33:39Z

Hi @mcuadros

thanks for the rebase here - just tried to run the tests and they failed - thoughts?

% make testacc TEST=./builtin/providers/ignition
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/01/03 08:32:48 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/ignition -v  -timeout 120m
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestValidateUnit
--- PASS: TestValidateUnit (0.00s)
=== RUN   TestIngnitionFileReplace
--- FAIL: TestIngnitionFileReplace (0.02s)
	testing.go:265: Step 0 error: Check failed: json: cannot unmarshal string into Go value of type types.Config
=== RUN   TestIngnitionFileAppend
--- FAIL: TestIngnitionFileAppend (0.02s)
	testing.go:265: Step 0 error: Check failed: json: cannot unmarshal string into Go value of type types.Config
=== RUN   TestIngnitionDisk
--- FAIL: TestIngnitionDisk (0.02s)
	testing.go:265: Step 0 error: Check failed: json: cannot unmarshal string into Go value of type types.Config
=== RUN   TestIngnitionFile
--- FAIL: TestIngnitionFile (0.03s)
	testing.go:265: Step 0 error: Check failed: json: cannot unmarshal string into Go value of type types.Config
=== RUN   TestIngnitionFilesystem
--- FAIL: TestIngnitionFilesystem (0.04s)
	testing.go:265: Step 0 error: Check failed: json: cannot unmarshal string into Go value of type types.Config
=== RUN   TestIngnitionGroup
--- FAIL: TestIngnitionGroup (0.03s)
	testing.go:265: Step 0 error: Check failed: json: cannot unmarshal string into Go value of type types.Config
=== RUN   TestIngnitionNetworkdUnit
--- FAIL: TestIngnitionNetworkdUnit (0.02s)
	testing.go:265: Step 0 error: Check failed: json: cannot unmarshal string into Go value of type types.Config
=== RUN   TestIngnitionRaid
--- FAIL: TestIngnitionRaid (0.03s)
	testing.go:265: Step 0 error: Check failed: json: cannot unmarshal string into Go value of type types.Config
=== RUN   TestIngnitionSystemdUnit
--- FAIL: TestIngnitionSystemdUnit (0.04s)
	testing.go:265: Step 0 error: Check failed: json: cannot unmarshal string into Go value of type types.Config
=== RUN   TestIngnitionUser
--- FAIL: TestIngnitionUser (0.04s)
	testing.go:265: Step 0 error: Check failed: json: cannot unmarshal string into Go value of type types.Config
FAIL
exit status 1
FAIL	github.com/hashicorp/terraform/builtin/providers/ignition	0.316s
make: *** [testacc] Error 1

Paul

stack72 · 2017-01-03T09:10:30Z

Hi @mcuadros
The issue here is that the vendoring isn't correct. I jsut resolved that test issue by running this command:

govendor fetch github.com/coreos/ignition/...

This then creates a new error:

% make testacc TEST=./builtin/providers/ignition                                                                      130 ↵ ✹ ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/01/03 09:08:41 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/ignition -v  -timeout 120m
# github.com/hashicorp/terraform/builtin/providers/ignition
builtin/providers/ignition/resource_ignition_filesystem.go:109: cannot use types.Path(d.Get("path").(string)) (type types.Path) as type *types.Path in field value
builtin/providers/ignition/resource_ignition_filesystem_test.go:56: invalid operation: f.Path != "/foo" (mismatched types *types.Path and string)
FAIL	github.com/hashicorp/terraform/builtin/providers/ignition [build failed]
make: *** [testacc] Error 2

mcuadros · 2017-01-03T11:00:11Z

Hi, @stack72

You found you problem the first want was when you updated the ignition library to the latest version, a inner type has change from a string to a types.Path being imposible to compile.

And the original error was a small problem, retrieving the module output, I was using OutputState.String instead of using the OutputState.Value

All test passing now.

stack72 · 2017-01-03T11:29:04Z

Fantastic :) This works now as expected

% make testacc TEST=./builtin/providers/ignition                                                                          130 ↵
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/01/03 11:27:14 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/ignition -v  -timeout 120m
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestValidateUnit
--- PASS: TestValidateUnit (0.00s)
=== RUN   TestIngnitionFileReplace
--- PASS: TestIngnitionFileReplace (0.02s)
=== RUN   TestIngnitionFileAppend
--- PASS: TestIngnitionFileAppend (0.02s)
=== RUN   TestIngnitionDisk
--- PASS: TestIngnitionDisk (0.02s)
=== RUN   TestIngnitionFile
--- PASS: TestIngnitionFile (0.03s)
=== RUN   TestIngnitionFilesystem
--- PASS: TestIngnitionFilesystem (0.04s)
=== RUN   TestIngnitionGroup
--- PASS: TestIngnitionGroup (0.03s)
=== RUN   TestIngnitionNetworkdUnit
--- PASS: TestIngnitionNetworkdUnit (0.02s)
=== RUN   TestIngnitionRaid
--- PASS: TestIngnitionRaid (0.02s)
=== RUN   TestIngnitionSystemdUnit
--- PASS: TestIngnitionSystemdUnit (0.04s)
=== RUN   TestIngnitionUser
--- PASS: TestIngnitionUser (0.04s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/ignition	0.307s

stack72 · 2017-01-03T11:29:12Z

Thanks for all of the work and the patience here!

mcuadros · 2017-01-03T11:34:49Z

Awesome! 🎉
You know when will be the next release?

stack72 · 2017-01-03T11:39:47Z

The xmas vacation ended this morning for us at HashiCorp so it will be in the next week I'd take a guess at

jwieringa · 2017-03-10T20:36:47Z

@mcuadros @stack72 It was fantastic to find the Ignition provider in Terraform, thank you!

ghost · 2020-04-15T02:34:35Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

mcuadros added 2 commits April 15, 2016 14:17

providers: ignition, basic config, version and config

c0b1bae

providers: ignition, user and passwd example, general cache implement…

ebe1436

…ation

mcuadros changed the title ~~Ignition provider~~ [WIP] Ignition provider Apr 15, 2016

vendor: Capture new dependency upstream-pkg

b3fadb0

jen20 added the new-provider label Apr 15, 2016

mcuadros added 8 commits April 17, 2016 01:55

providers: ignition ignition_user

7c70594

Merge branch 'ignition' of github.com:mcuadros/terraform into ignition

024d83a

providers: ignition ignition_disk, ignition_group and ignition_raid

0749be6

providers: ignition_file and ignition_filesystem

8e1a2ec

providers: ignition_systemd_unit and ignition_networkd_unit

45e846d

providers: ignition_config improvements

3626576

vendor: Capture new dependency upstream-pkg

1e20b98

providers: ignition main

0db9311

mcuadros changed the title ~~[WIP] Ignition provider~~ Ignition provider Apr 17, 2016

mcuadros added 2 commits April 19, 2016 00:25

documentation: ignition provider

f9b37e7

providers: ignition minor changes

95c6a46

mcuadros added 2 commits July 31, 2016 23:34

sync

01b8528

providers: ignition, fix test

81213cd

rebase

00db1eb

stack72 self-assigned this Jan 3, 2017

fixing tests and latest versions

888e93d

stack72 merged commit 85f0fba into hashicorp:master Jan 3, 2017

gustav-b mentioned this pull request Jan 10, 2017

ignition_systemd_unit should be allowed with no content and only dropin #11133

Closed

ghost locked and limited conversation to collaborators Apr 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ignition provider #6189

Ignition provider #6189

mcuadros commented Apr 15, 2016 •

edited

Loading

jen20 commented Apr 15, 2016

mcuadros commented Apr 15, 2016

mcuadros commented Apr 18, 2016

mcuadros commented Apr 26, 2016

mcuadros commented Jun 9, 2016

rdeusser commented Jul 21, 2016

mcuadros commented Aug 1, 2016

adamcstephens commented Jan 3, 2017

jen20 commented Jan 3, 2017

mcuadros commented Jan 3, 2017

stack72 commented Jan 3, 2017

stack72 commented Jan 3, 2017

mcuadros commented Jan 3, 2017

stack72 commented Jan 3, 2017

stack72 commented Jan 3, 2017

mcuadros commented Jan 3, 2017

stack72 commented Jan 3, 2017

jwieringa commented Mar 10, 2017

ghost commented Apr 15, 2020

Ignition provider #6189

Ignition provider #6189

Conversation

mcuadros commented Apr 15, 2016 • edited Loading

jen20 commented Apr 15, 2016

mcuadros commented Apr 15, 2016

mcuadros commented Apr 18, 2016

mcuadros commented Apr 26, 2016

mcuadros commented Jun 9, 2016

rdeusser commented Jul 21, 2016

mcuadros commented Aug 1, 2016

adamcstephens commented Jan 3, 2017

jen20 commented Jan 3, 2017

mcuadros commented Jan 3, 2017

stack72 commented Jan 3, 2017

stack72 commented Jan 3, 2017

mcuadros commented Jan 3, 2017

stack72 commented Jan 3, 2017

stack72 commented Jan 3, 2017

mcuadros commented Jan 3, 2017

stack72 commented Jan 3, 2017

jwieringa commented Mar 10, 2017

ghost commented Apr 15, 2020

mcuadros commented Apr 15, 2016 •

edited

Loading