Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Support Elastic Beanstalk option settings with optional parameters #6476

Closed
dharrisio opened this issue May 4, 2016 · 5 comments

Comments

@dharrisio
Copy link
Contributor

In Elastic Beanstalk the aws:autoscaling:scheduledaction option settings require an additional parameter. After glancing through all the option settings, it looks like this is currently the only set of settings requiring more than namespace, name and value.

[http://docs.aws.amazon.com/elasticbeanstalk/latest/dg/command-options-general.html#command-options-general-autoscalingscheduledaction]

Thanks to @rurreac for bringing this issue up in #3157. I created this issue to track it separately from the old, closed issue.

The fix for this looks fairly simple, as we may simply need to add an optional parameter in the setting schema. The hashing functions would also need to update to use the resource_name parameter in the hash when it is specified.

@luphaz
Copy link

luphaz commented Jun 22, 2016

Hello @dharrisio,
Do you have any information regarding the implementation of this missing feature?

@dharrisio
Copy link
Contributor Author

@WolfHazardous I should be able to get to this sometime this week.

@luphaz
Copy link

luphaz commented Jun 27, 2016

Hi,

Waiting the implementation I've used a provisioner on the environment resource to achieve what I need.

provisioner "local-exec" {
      command = "aws elasticbeanstalk update-environment --environment-id ${aws_elastic_beanstalk_environment.env.id} --cli-input-json file://${path.root}/beanstalk-update-env.json"
}

And the file beanstalk-options.json contains the required option with ResourceName :

{
    "OptionSettings": [
        {
            "ResourceName": "downweeknight",
            "Namespace": "aws:autoscaling:scheduledaction",
            "OptionName": "MinSize",
            "Value": "0"
        }...

As soon as the implementation will be publicly available I'll replace the hack :)

Cheers

@stack72
Copy link
Contributor

stack72 commented Jun 28, 2016

Closed via #7376

@stack72 stack72 closed this as completed Jun 28, 2016
@ghost
Copy link

ghost commented Apr 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants