Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/vsphere: missing memory reservation in deployVirtualMachine #6482

Merged
merged 1 commit into from
May 4, 2016
Merged

provider/vsphere: missing memory reservation in deployVirtualMachine #6482

merged 1 commit into from
May 4, 2016

Conversation

thetuxkeeper
Copy link
Contributor

@thetuxkeeper thetuxkeeper commented May 4, 2016

Fixes this one:

==> Checking that code complies with gofmt requirements...
/home/dpossmann/go/bin/stringer
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/vsphere -v -run=TestAccVSphereVirtualMachine_basic -timeout 120m
=== RUN   TestAccVSphereVirtualMachine_basic
--- FAIL: TestAccVSphereVirtualMachine_basic (77.07s)
        testing.go:172: Step 0 error: Check failed: Check 5/9 error: vsphere_virtual_machine.foo: Attribute 'memory_reservation' expected "4096", got "0"
FAIL
exit status 1
FAIL    github.com/hashicorp/terraform/builtin/providers/vsphere        77.082s

@jen20
Copy link
Contributor

jen20 commented May 4, 2016

LGTM! Thanks @thetuxkeeper!

@jen20 jen20 merged commit 63849a5 into hashicorp:master May 4, 2016
@thetuxkeeper thetuxkeeper deleted the fix-memory-reservation-templated branch May 9, 2016 09:34
@ghost
Copy link

ghost commented Apr 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants