Heroku SSL certificate support #672
Conversation
| d.Set("name", cert.Name) | ||
| d.Set("cname", cert.CName) | ||
| d.Set("created_at", cert.CreatedAt) | ||
| d.Set("updated_at", cert.UpdatedAt) |
There was a problem hiding this comment.
You are updating fields in the schema that do not exist. If you want to save this info in the state of the resource, you have to add these fields as computed fields to your schema.
There was a problem hiding this comment.
you're right - there should be only certificate_chain, name and cname here.
|
@svanharmelen btw - do you prefer squashed commits before merging into master ? |
|
LGTM 👍 If the commits start piling up a squashed commit has my (personal) preference, but in this case this should be fine! /CC @armon |
|
Thanks! |
Heroku SSL certificate support
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
No description provided.