provider/aws: Make 'stage_name' required in api_gateway_deployment

[jrasell]

Currently the stage_name variable under the aws_api_gateway_deployment resource is listed as optional. However, when running a terraform apply on a configuration which omits the stage_name variable the following exception is raised from the AWS API:

aws_api_gateway_deployment.jrasell-test-terraform: Error creating API Gateway Deployment: BadRequestException: Stage name must be non-empty
        status code: 400, request id: 934b9e58-1e8c-11e6-b1af-15e92240819e

Terraform v0.6.16

This request therefore updates the variable stage_name to be required.
The associated documentation as also been updated the reflect this.

[stack72]

Hi @jrasell

Thanks so much for this. you are indeed correct, according to the AWS docs, it does look required :)

The tests pass :)

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSAPIGatewayDeployment' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSAPIGatewayDeployment -timeout 120m
=== RUN   TestAccAWSAPIGatewayDeployment_basic
--- PASS: TestAccAWSAPIGatewayDeployment_basic (34.22s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    34.257s

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.