provider/aws: Add support for encryption and kms_key_id to aws_ami
#7181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -506,6 +506,20 @@ func resourceAwsAmiCommonSchema(computed bool) map[string]*schema.Schema { | |||
| }, | |||
| }, | |||
|
|
|||
| "encrypted": &schema.Schema{ | |||
There was a problem hiding this comment.
I don't feel like these should be added to resourceAwsAmiCommonSchema, since they only apply to the aws_ami_copy resource. Can we add them where we add source_ami_region and source_ami_id, instead?
|
@catsby you are indeed correct on both counts :) Added as requested - test are just going through atm |
This fixes #7157. It doesn't change the way aws_ami works ``` make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSAMICopy' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /vendor/) TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSAMICopy -timeout 120m === RUN TestAccAWSAMICopy --- PASS: TestAccAWSAMICopy (479.75s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 479.769s ```
stack72
force-pushed
the
ami_copy_encrypted
branch
from
63674f2 to
2ab9813
Compare
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7157. It doesn't change the way aws_ami works