core: Correctly format nested outputs #7608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis says " |
jen20
force-pushed
the
nested-output-formatting
branch
from
034262d
to
e1ce2ab
Compare
|
Formating fixed now @phinze! |
|
I would love to see a unit test or two around this, but since it's cosmetic and I've seen it demo'd I'll allow it! 😄 👍 LGTM |
This commit pretty prints outputs which consist of nested complex structures (e.g. lists of lists, lists of maps). Fixes #7143.
jen20
force-pushed
the
nested-output-formatting
branch
from
e1ce2ab
to
afb56c0
Compare
|
@phinze I've added some tests and a new |
This commit removes the ability to index into complex output types using
`terraform output a_list 1` (for example), and adds a `-json` flag to
the `terraform output` command, such that the output can be piped
through a post-processor such as jq or json. This removes the need to
allow arbitrary traversal of nested structures.
It also adds tests of human readable ("normal") output with nested lists
and maps, and of the new JSON output.
jen20
force-pushed
the
nested-output-formatting
branch
from
afb56c0
to
b4048df
Compare
| @@ -53,19 +53,19 @@ func TestOutput(t *testing.T) { | |||
| func TestModuleOutput(t *testing.T) { | |||
| originalState := &terraform.State{ | |||
| Modules: []*terraform.ModuleState{ | |||
| &terraform.ModuleState{ | |||
| { | |||
|
LGTM! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit pretty prints outputs which consist of nested complex structures (e.g. lists of lists, lists of maps).
Fixes #7143.
cc @phinze