Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Paginate roles #7779

Merged
merged 2 commits into from
Aug 16, 2016
Merged

provider/aws: Paginate roles #7779

merged 2 commits into from
Aug 16, 2016

Conversation

raylu
Copy link

@raylu raylu commented Jul 23, 2016

This includes a cherry-picked #6726. Instead of merging, you probably want to merge @miquella's and cherry-pick this.

@stack72
Copy link
Contributor

stack72 commented Aug 14, 2016

Hi @raylu

Thanks for the PR here. #6726 has been merged now (thanks for the reminder there). Would you mind rebasing this PR and adding a test to show that the pagination works as expected? (I added one for the groups https://github.com/hashicorp/terraform/blob/master/builtin/providers/aws/resource_aws_iam_group_membership_test.go#L60)

thanks

Paul

@stack72 stack72 added the waiting-response An issue/pull request is waiting for a response from the community label Aug 14, 2016
@stack72 stack72 self-assigned this Aug 14, 2016
@raylu
Copy link
Author

raylu commented Aug 15, 2016

How's that?

@stack72 stack72 merged commit f1fdffc into hashicorp:master Aug 16, 2016
@stack72
Copy link
Contributor

stack72 commented Aug 16, 2016

Hi @raylu

I made 1 small change - f9e86a5 - this changed the paginated test to use the correct config :)

apart from that, it looks good and I manually merged it. Thanks for all the help here

Paul

@ghost
Copy link

ghost commented Apr 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 23, 2020
@qaisjp-stripe qaisjp-stripe deleted the paginate_roles branch September 29, 2021 22:06
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug provider/aws waiting-response An issue/pull request is waiting for a response from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants