Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helper: create validation package to provide common validation functions #8103

Merged
merged 2 commits into from
Oct 7, 2016

Conversation

pmcatominey
Copy link
Contributor

No description provided.

@pmcatominey
Copy link
Contributor Author

Hi,

This is a suggestion on removing the need for writing multiple variations of the same logic when validating a schema.

I've used the traffic_manager_profile as an example of what the functions can replace.

Cheers,
Peter

…on helpers

Updated:
	traffic_manager_profile
	traffic_manager_endpoint
@jen20
Copy link
Contributor

jen20 commented Sep 2, 2016

Hi @pmcatominey! This looks like a good idea to me. We're gearing up to release so I don't want to merge this immediately beforehand, I'd like to get at least one run of acceptance testing on it. We'll circle back around to this soon though.

@stack72
Copy link
Contributor

stack72 commented Oct 7, 2016

ok, let's get this merged now :) We have time between now and 0.7.6 to see if there are any issues we need to work out

@pmcatominey can you keep an eye on the nightly tests for AzureRM? https://travis-ci.org/hashicorp/terraform/builds

@stack72 stack72 merged commit 4ac7d0a into hashicorp:master Oct 7, 2016
@pmcatominey pmcatominey deleted the validation-helper branch October 7, 2016 12:43
@ghost
Copy link

ghost commented Apr 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants