Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vSphere Provider: Fix #8253 #8276

Merged
merged 1 commit into from
Jan 20, 2017
Merged

vSphere Provider: Fix #8253 #8276

merged 1 commit into from
Jan 20, 2017

Conversation

cvlc
Copy link
Contributor

@cvlc cvlc commented Aug 18, 2016

Body:
If we only have one networkInterface, deviceID should be 0 to ensure that it selects the first element of the networkInterfaces array.

I don't have a development vSphere environment handy for running tests and have only used it with one configuration, hence the WIP.

be 0 to ensure that it selects the first element of the
networkInterfaces array.
@astraios
Copy link

Hi,

Is there any way we could have this merged, I'm still experimenting this issue with 0.7.3.

Thanks

Copy link
Contributor

@justinclayton justinclayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for us in our vCenter 6 environment. LGTM!

@justinclayton
Copy link
Contributor

Yo, this has been well tested at this point and is a very minor change to fix an otherwise crashing bug. We've been working off a fork for a while now; any chance this can make it into 0.7.7?

@cvlc cvlc changed the title [WIP] vSphere Provider: Fix #8253 vSphere Provider: Fix #8253 Oct 21, 2016
@jgeerds
Copy link

jgeerds commented Oct 28, 2016

This patch works for us as well. What blocks this PR from being merged?

@cvlc
Copy link
Contributor Author

cvlc commented Nov 1, 2016

Maybe we need @stack72 or somebody else with write access?

@RicharddeJong
Copy link

My Terraform is now also crashing on the same point. Can someone add this to the main branch please?

@stack72
Copy link
Contributor

stack72 commented Nov 14, 2016

Hi friends,

Sorry that we haven't merged this in. We are currently in the process of setting up some acceptance testing infrastructure for vsphere. If someone already has ran the acceptance tests with this patch, please can they post the results here?

This will help us immensely!

Thanks

Paul

@jgeerds
Copy link

jgeerds commented Nov 14, 2016

@stack72: Do the tests have "unexpected" side effects? (e.g. remove all VMs from the cluster or not properly clean up?)

@curator
Copy link

curator commented Dec 22, 2016

@stack72 With some fumbling about, my team was able to setup a testing environment and the acceptance tests for networking ran clean with the patches.

@krobertson
Copy link

This is also working on my local vSphere 6 cluster. Would be great to have it merge and be in the next release.

@curator
Copy link

curator commented Jan 11, 2017

@stack72 Do you need anything else before merging this?

@matt-deboer
Copy link
Contributor

Any chance this could be merged soon?
Already using it, but hate maintaining a fork...

@stack72 stack72 merged commit ceccdb8 into hashicorp:master Jan 20, 2017
@cvlc cvlc deleted the cvlc/vsphere-fix-single-interface branch January 26, 2017 17:51
@ghost
Copy link

ghost commented Apr 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants