-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vSphere Provider: Fix #8253 #8276
vSphere Provider: Fix #8253 #8276
Conversation
be 0 to ensure that it selects the first element of the networkInterfaces array.
Hi, Is there any way we could have this merged, I'm still experimenting this issue with 0.7.3. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for us in our vCenter 6 environment. LGTM!
Yo, this has been well tested at this point and is a very minor change to fix an otherwise crashing bug. We've been working off a fork for a while now; any chance this can make it into 0.7.7? |
This patch works for us as well. What blocks this PR from being merged? |
Maybe we need @stack72 or somebody else with write access? |
My Terraform is now also crashing on the same point. Can someone add this to the main branch please? |
Hi friends, Sorry that we haven't merged this in. We are currently in the process of setting up some acceptance testing infrastructure for vsphere. If someone already has ran the acceptance tests with this patch, please can they post the results here? This will help us immensely! Thanks Paul |
@stack72: Do the tests have "unexpected" side effects? (e.g. remove all VMs from the cluster or not properly clean up?) |
@stack72 With some fumbling about, my team was able to setup a testing environment and the acceptance tests for networking ran clean with the patches. |
This is also working on my local vSphere 6 cluster. Would be great to have it merge and be in the next release. |
@stack72 Do you need anything else before merging this? |
Any chance this could be merged soon? |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Body:
If we only have one networkInterface, deviceID should be 0 to ensure that it selects the first element of the networkInterfaces array.
I don't have a development vSphere environment handy for running tests and have only used it with one configuration, hence the WIP.