provider/azurerm: support Diagnostics Profile #8277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| networkProfile := expandAzureRmVirtualMachineNetworkProfile(d) | ||
| vmSize := d.Get("vm_size").(string) | ||
| properties := compute.VirtualMachineProperties{ | ||
| NetworkProfile: &networkProfile, | ||
| DiagnosticsProfile: &diagnosticsProfile, |
There was a problem hiding this comment.
Will there always be a diagnosticsProfile or should we check that this isn't an empty profile before adding?
|
thanks for the PR here - I left a few comments. Once we can get these sorted, we can get this merged Thanks Paul |
stack72
added
the
waiting-response
jgoldschrafe
force-pushed
the
feature/azurerm-diagnostics-profile
branch
from
05b1ac5 to
e4ba41a
Compare
Add support for a diagnostics profile, which allows boot diagnostics to be enabled on a virtual machine.
jgoldschrafe
force-pushed
the
feature/azurerm-diagnostics-profile
branch
from
e4ba41a to
08f2e67
Compare
|
Thanks for the feedback! I've updated to address these concerns. |
| @@ -425,6 +453,11 @@ func resourceArmVirtualMachineCreate(d *schema.ResourceData, meta interface{}) e | |||
| StorageProfile: &storageProfile, | |||
| } | |||
|
|
|||
| if _, ok := d.GetOk("diagnostics_profile"); ok { | |||
| diagnosticsProfile := expandAzureRmVirtualMachineDiagnosticsProfile(d) | |||
| properties.DiagnosticsProfile = &diagnosticsProfile | |||
jen20
removed
the
waiting-response
|
Just been running the tests here - the test you added for the diagnostics works as expected. Unfortunately, the test Can you have a look and see if there are any issues with running diagnostics with unattendedConfig? thanks Paul |
stack72
added
the
waiting-response
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for a diagnostics profile, which allows boot diagnostics to be enabled on a virtual machine.