provider/aws: Skip detaching when aws_internet_gateway not found

[Bowbaq]

Deleting an aws_internet_gateway intermittently fails because the gateway fails to detach, and this is considered an error.

The gateway should only be deleted by terraform after it is detached, so there's no reason for it to disappear at this stage in the normal flow. This makes InvalidInternetGatewayID.NotFound a retryable error.

[stack72]

Hey @Bowbaq

Thanks for the work here :) This is a valid use case and the tests are looking good!

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSInternetGateway_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/09/04 00:48:48 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSInternetGateway_ -timeout 120m
=== RUN   TestAccAWSInternetGateway_importBasic
--- PASS: TestAccAWSInternetGateway_importBasic (53.18s)
=== RUN   TestAccAWSInternetGateway_basic
--- PASS: TestAccAWSInternetGateway_basic (100.03s)
=== RUN   TestAccAWSInternetGateway_delete
--- PASS: TestAccAWSInternetGateway_delete (75.74s)
=== RUN   TestAccAWSInternetGateway_tags
--- PASS: TestAccAWSInternetGateway_tags (83.93s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    312.902s

Paul

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.