Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: new data source for aws_subnet #8860

Closed
zms opened this issue Sep 15, 2016 · 5 comments
Closed

Feature request: new data source for aws_subnet #8860

zms opened this issue Sep 15, 2016 · 5 comments

Comments

@zms
Copy link

zms commented Sep 15, 2016

Is there a way to query subnets using new data source like we can for AWS AMIs? If not, would you please consider adding this?

Additional data sources that would be very useful: VPC, routing tables, DHCP option set, security groups and network ACLs.

Scenario: This is will allow me to query and use subnets dynamically when deploying specific types of workloads in subnets suitable for them (based on NACLs and routing etc.) without having to query them externally and populating variables before calling terraform. The scripts then also become portable between VPCs without hardcoded dependencies (as long filter pattern is satisfied).

@apparentlymart
Copy link
Contributor

Thanks for the feature request, @zms.

I'm working on this over in #6819. I still have a little work to do there before it can be merged but hopefully it won't be too long.

I haven't covered everything you've listed in there yet, but we should be able to add the remaining stuff pretty easily afterwards since the structure of all of these is basically the same.

@mfischer-zd
Copy link
Contributor

Yes please!

@zms
Copy link
Author

zms commented Sep 20, 2016

@apparentlymart: thank you. looking forward to it. just say the word if you need the feature tested. :)

@apparentlymart
Copy link
Contributor

I just realized that I left this dangling when #6819 was merged.

aws_subnet was introduced in the 0.7.6 release. We also added aws_vpc in 0.7.6 and aws_security_group will be in the forthcoming 0.7.8 release.

We didn't get routing tables or DHCP option sets in yet, but they are unlikely to be difficult since they can re-use the helper functions added for the first set of VPC data sources, but I'm going to close this issue out and we can attack those in separate PRs.

Thanks again for the feature request, and for the patience while I got it done!

@ghost
Copy link

ghost commented Apr 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants