Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "arn" attribute to AWS Lambda alias #9390

Merged
merged 1 commit into from
Oct 16, 2016

Conversation

tmshn
Copy link
Contributor

@tmshn tmshn commented Oct 16, 2016

What has changed?

Per title.

Why it's needed?

Without the arn attribute, you have to combine function_name and name to specify arn, which is very troublesome.
For instance,

resource "aws_cloudwatch_event_target" "my_event_target" {
  rule = "my-event-rule"
  target_id = "tf-my-event-target"
  arn = "${aws_lambda_alias.my_alias.arn}:${aws_lambda_alias.my_alias.name}"
}

@apparentlymart
Copy link
Contributor

$ make testacc TEST=./builtin/providers/aws TESTARGS="-run=TestAccAWSLambdaAlias_basic"
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/10/16 10:00:27 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSLambdaAlias_basic -timeout 120m
=== RUN   TestAccAWSLambdaAlias_basic
--- PASS: TestAccAWSLambdaAlias_basic (19.70s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    19.717s

Copy link
Contributor

@apparentlymart apparentlymart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tmshn! This looks great.

@apparentlymart apparentlymart merged commit 8ec06e8 into hashicorp:master Oct 16, 2016
terraformbot pushed a commit that referenced this pull request Oct 17, 2016
[origin/master] Merge #9390: arn attribute for AWS Lambda alias
f86198c
terraformbot pushed a commit that referenced this pull request Oct 17, 2016
[origin/master] Merge #9390: arn attribute for AWS Lambda alias
f86198c
terraformbot pushed a commit that referenced this pull request Oct 17, 2016
[origin/master] Merge #9390: arn attribute for AWS Lambda alias
f86198c
terraformbot pushed a commit that referenced this pull request Oct 17, 2016
[origin/master] Merge #9390: arn attribute for AWS Lambda alias
f86198c
terraformbot pushed a commit that referenced this pull request Oct 17, 2016
[origin/master] Merge #9390: arn attribute for AWS Lambda alias
f86198c
terraformbot pushed a commit that referenced this pull request Oct 17, 2016
[origin/master] Merge #9390: arn attribute for AWS Lambda alias
f86198c
terraformbot pushed a commit that referenced this pull request Oct 17, 2016
[origin/master] Merge #9390: arn attribute for AWS Lambda alias
f86198c
terraformbot pushed a commit that referenced this pull request Oct 17, 2016
[origin/master] Merge #9390: arn attribute for AWS Lambda alias
f86198c
terraformbot pushed a commit that referenced this pull request Oct 17, 2016
[origin/master] Merge #9390: arn attribute for AWS Lambda alias
f86198c
terraformbot pushed a commit that referenced this pull request Oct 17, 2016
[origin/master] Merge #9390: arn attribute for AWS Lambda alias
f86198c
terraformbot pushed a commit that referenced this pull request Oct 17, 2016
[origin/master] Merge #9390: arn attribute for AWS Lambda alias
f86198c
terraformbot pushed a commit that referenced this pull request Oct 17, 2016
[origin/master] Merge #9390: arn attribute for AWS Lambda alias
f86198c
terraformbot pushed a commit that referenced this pull request Oct 17, 2016
[origin/master] Merge #9390: arn attribute for AWS Lambda alias
f86198c
terraformbot pushed a commit that referenced this pull request Oct 17, 2016
[origin/master] Merge #9390: arn attribute for AWS Lambda alias
f86198c
terraformbot pushed a commit that referenced this pull request Oct 17, 2016
[origin/master] Merge #9390: arn attribute for AWS Lambda alias
f86198c
terraformbot pushed a commit that referenced this pull request Oct 17, 2016
[origin/master] Merge #9390: arn attribute for AWS Lambda alias
f86198c
terraformbot pushed a commit that referenced this pull request Oct 17, 2016
[origin/master] Merge #9390: arn attribute for AWS Lambda alias
f86198c
terraformbot pushed a commit that referenced this pull request Oct 17, 2016
[origin/master] Merge #9390: arn attribute for AWS Lambda alias
f86198c
terraformbot pushed a commit that referenced this pull request Oct 17, 2016
[origin/master] Merge #9390: arn attribute for AWS Lambda alias
f86198c
terraformbot pushed a commit that referenced this pull request Oct 17, 2016
[origin/master] Merge #9390: arn attribute for AWS Lambda alias
f86198c
terraformbot pushed a commit that referenced this pull request Oct 17, 2016
[origin/master] Merge #9390: arn attribute for AWS Lambda alias
f86198c
terraformbot pushed a commit that referenced this pull request Oct 17, 2016
[origin/master] Merge #9390: arn attribute for AWS Lambda alias
f86198c
terraformbot pushed a commit that referenced this pull request Oct 17, 2016
[origin/master] Merge #9390: arn attribute for AWS Lambda alias
f86198c
terraformbot pushed a commit that referenced this pull request Oct 17, 2016
[origin/master] Merge #9390: arn attribute for AWS Lambda alias
f86198c
terraformbot pushed a commit that referenced this pull request Oct 17, 2016
[origin/master] Merge #9390: arn attribute for AWS Lambda alias
f86198c
@ghost
Copy link

ghost commented Apr 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants