Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Added aws_api_gateway_rest_api created_date attribute #9532

Merged
merged 1 commit into from
Nov 14, 2016

Conversation

Ninir
Copy link
Contributor

@Ninir Ninir commented Oct 23, 2016

Description

This allows to get the API key value when using the aws_api_gateway_rest_api resource.

Relevant Terraform version

Checked against: Terraform v0.7.8-dev (7cb2e69+CHANGES)

@stack72
Copy link
Contributor

stack72 commented Nov 14, 2016

Hi @Ninir

Just checked through this - unfortunately, the tests failed:

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSAPIGatewayRestApi_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/11/14 09:52:33 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSAPIGatewayRestApi_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayRestApi_basic
--- FAIL: TestAccAWSAPIGatewayRestApi_basic (13.73s)
    testing.go:265: Step 0 error: Check failed: Check 5/5 error: aws_api_gateway_rest_api.test: Attribute 'created_date' expected to be set
FAIL
exit status 1
FAIL    github.com/hashicorp/terraform/builtin/providers/aws    13.747s
make: *** [testacc] Error 1

Please can you take a look?

Thanks

Paul

@stack72 stack72 added the waiting-response An issue/pull request is waiting for a response from the community label Nov 14, 2016
@Ninir Ninir force-pushed the aws_apigw_rest_api_date branch from 9d4e491 to 2f8bc97 Compare November 14, 2016 10:40
@Ninir
Copy link
Contributor Author

Ninir commented Nov 14, 2016

Hey @stack72

Fixed the code:

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSAPIGatewayRestApi_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/11/14 11:39:19 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSAPIGatewayRestApi_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayRestApi_basic
--- PASS: TestAccAWSAPIGatewayRestApi_basic (14.91s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    14.941s

However, tests are failing at a point... can't tell, will try to investigate.

@Ninir Ninir force-pushed the aws_apigw_rest_api_date branch from 2f8bc97 to a88b25c Compare November 14, 2016 10:56
@stack72
Copy link
Contributor

stack72 commented Nov 14, 2016

Thanks for the fast fix here :) This looks better now

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSAPIGatewayRestApi_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/11/14 12:07:45 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSAPIGatewayRestApi_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayRestApi_basic
--- PASS: TestAccAWSAPIGatewayRestApi_basic (31.38s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    31.402s

@stack72 stack72 merged commit 2423133 into hashicorp:master Nov 14, 2016
@ghost
Copy link

ghost commented Apr 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement provider/aws waiting-response An issue/pull request is waiting for a response from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants