provider/aws: Exposed aws_api_gateway_deployment.created_date attribute

[Ninir]

Description

This allows to get the API GW deployment created_date when using the aws_api_gateway_deployment resource.

Relevant Terraform version

Checked against: Terraform v0.7.8-dev (7cb2e69+CHANGES)

[kwilczynski]

@Ninir hi there! Thank you so much for the contribution!

Allow me to ask - what is your use case so that you wish to expose creation date? I am not entirely sure why use it might have.

Thank you in advance!

[Ninir]

Hi @kwilczynski,

This is only for information purposes!
Found it could be useful to provide as much data as the sdk / API allows us to have.

Regarding a use-case, I am planning to add another PR which will expose the last_deployment data (saw an attribute for this), and accordingly, the number of deployments.
This would give some data we have in the aws console, and not yet in Terraform! :)

Do you see any blocking-stuff to this?

[stack72]

Hi @Ninir

Thanks for the work here - unfortunately the tests fail :(

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSAPIGatewayDeployment_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/11/14 10:05:31 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSAPIGatewayDeployment_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayDeployment_basic
--- FAIL: TestAccAWSAPIGatewayDeployment_basic (24.91s)
    testing.go:265: Step 0 error: Check failed: Check 5/5 error: aws_api_gateway_deployment.test: Attribute 'created_date' expected to be set
FAIL
exit status 1
FAIL    github.com/hashicorp/terraform/builtin/providers/aws    24.933s
make: *** [testacc] Error 1

Please can you take a look?

Thanks

Paul

[Ninir]

@stack72 Updated the code.

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSAPIGatewayDeployment_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/11/14 11:18:23 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSAPIGatewayDeployment_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayDeployment_basic
--- PASS: TestAccAWSAPIGatewayDeployment_basic (12.31s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    12.339s

It is weird it was passing without the last change (reading after creating) 😅

[stack72]

This looks better now @Ninir :) Thanks!

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSAPIGatewayDeployment_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/11/14 12:10:46 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSAPIGatewayDeployment_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayDeployment_basic
--- PASS: TestAccAWSAPIGatewayDeployment_basic (33.66s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    33.678s

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.