helper/schema: only mark "ForceNew" on resources that cause the ForceNew #9613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellh
commented
Oct 26, 2016
| }, | ||
|
|
||
| Err: false, | ||
| }, | ||
| } | ||
|
|
||
| for tn, tc := range cases { |
There was a problem hiding this comment.
All the changes in this section here (below) are me just converting this to use subtests so you can run one at a time if needed.
jbardin
approved these changes
Oct 28, 2016
|
Thanks, going to hold for a TF 0.8 merge for beta. |
mitchellh
force-pushed
the
b-accurate-forcenew
branch
from
a29b793 to
2b023da
Compare
Fixes #2748 This changes the diff to only mark "forces new resource" on the fields that actually caused the new resource, not every field that changed. This makes diffs much more accurate. I'd like to request a review but I'm going to defer merging until Terraform 0.8. Changes like this are very possible to cause "diffs didn't match" errors and I want some real world testing in a beta before we hit prod with this.
mitchellh
force-pushed
the
b-accurate-forcenew
branch
from
2b023da to
e45debe
Compare
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2748
This changes the diff to only mark "forces new resource" on the fields
that actually caused the new resource, not every field that changed.
This makes diffs much more accurate.
I'd like to request a review but I'm going to defer merging until
Terraform 0.8. Changes like this are very possible to cause "diffs
didn't match" errors and I want some real world testing in a beta before
we hit prod with this.