Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add support for AutoMinorVersionUpgrade to aws_elasticache_replication_group resource. #9657

Conversation

kwilczynski
Copy link
Contributor

This commit adds an ability to modify the AutoMinorVersionUpgrade property of the
Replication Group (which is enabled by default) accordingly.

Signed-off-by: Krzysztof Wilczynski krzysztof.wilczynski@linux.com

…ion_group resource.

This commit adds an ability to modify the `AutoMinorVersionUpgrade` property of the
Replication Group (which is enabled by default) accordingly.

Signed-off-by: Krzysztof Wilczynski <krzysztof.wilczynski@linux.com>
@kwilczynski kwilczynski changed the title Add support for AutoMinorVersionUpgrade to aws_elasticache_replication_group resource. provider/aws: Add support for AutoMinorVersionUpgrade to aws_elasticache_replication_group resource. Oct 27, 2016
@kwilczynski
Copy link
Contributor Author

Resolves #9652.

@kwilczynski
Copy link
Contributor Author

Acceptance tests are passing (somewhat - my account has no feature available):

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSElasticacheReplicationGroup_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/10/27 19:25:06 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSElasticacheReplicationGroup_ -timeout 120m
=== RUN   TestAccAWSElasticacheReplicationGroup_importBasic
--- FAIL: TestAccAWSElasticacheReplicationGroup_importBasic (15.09s)
    testing.go:265: Step 0 error: Error applying: 1 error(s) occurred:

        * aws_elasticache_security_group.bar: Error creating CacheSecurityGroup: InvalidParameterValue: Use of cache security groups is not permitted in this API version for your account.
            status code: 400, request id: c349b090-9c72-11e6-979a-ad946a1a73fe
=== RUN   TestAccAWSElasticacheReplicationGroup_basic
--- FAIL: TestAccAWSElasticacheReplicationGroup_basic (14.56s)
    testing.go:265: Step 0 error: Error applying: 1 error(s) occurred:

        * aws_elasticache_security_group.bar: Error creating CacheSecurityGroup: InvalidParameterValue: Use of cache security groups is not permitted in this API version for your account.
            status code: 400, request id: cb95413f-9c72-11e6-bec9-e5c185dee99a
=== RUN   TestAccAWSElasticacheReplicationGroup_updateDescription
--- FAIL: TestAccAWSElasticacheReplicationGroup_updateDescription (18.22s)
    testing.go:265: Step 0 error: Error applying: 1 error(s) occurred:

        * aws_elasticache_security_group.bar: Error creating CacheSecurityGroup: InvalidParameterValue: Use of cache security groups is not permitted in this API version for your account.
            status code: 400, request id: d5d8f943-9c72-11e6-bec9-e5c185dee99a
=== RUN   TestAccAWSElasticacheReplicationGroup_updateNodeSize
--- FAIL: TestAccAWSElasticacheReplicationGroup_updateNodeSize (16.47s)
    testing.go:265: Step 0 error: Error applying: 1 error(s) occurred:

        * aws_elasticache_security_group.bar: Error creating CacheSecurityGroup: InvalidParameterValue: Use of cache security groups is not permitted in this API version for your account.
            status code: 400, request id: df81a8cb-9c72-11e6-bec9-e5c185dee99a
=== RUN   TestAccAWSElasticacheReplicationGroup_updateParameterGroup
--- FAIL: TestAccAWSElasticacheReplicationGroup_updateParameterGroup (15.83s)
    testing.go:265: Step 0 error: Error applying: 1 error(s) occurred:

        * aws_elasticache_security_group.bar: Error creating CacheSecurityGroup: InvalidParameterValue: Use of cache security groups is not permitted in this API version for your account.
            status code: 400, request id: e9b50c27-9c72-11e6-8b0d-850f0a8b375a
=== RUN   TestAccAWSElasticacheReplicationGroup_vpc
--- PASS: TestAccAWSElasticacheReplicationGroup_vpc (740.02s)
=== RUN   TestAccAWSElasticacheReplicationGroup_multiAzInVpc
--- PASS: TestAccAWSElasticacheReplicationGroup_multiAzInVpc (1225.06s)
=== RUN   TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2
--- PASS: TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2 (1032.86s)
FAIL
exit status 1
FAIL    github.com/hashicorp/terraform/builtin/providers/aws    3078.148s
make: *** [testacc] Error 1

@stack72
Copy link
Contributor

stack72 commented Oct 27, 2016

This LGTM! Thanks @kwilczynski!

@stack72 stack72 merged commit a078b89 into hashicorp:master Oct 27, 2016
mathieuherbert pushed a commit to mathieuherbert/terraform that referenced this pull request Oct 30, 2016
…ion_group resource. (hashicorp#9657)

This commit adds an ability to modify the `AutoMinorVersionUpgrade` property of the
Replication Group (which is enabled by default) accordingly.

Signed-off-by: Krzysztof Wilczynski <krzysztof.wilczynski@linux.com>
gusmat pushed a commit to gusmat/terraform that referenced this pull request Dec 6, 2016
…ion_group resource. (hashicorp#9657)

This commit adds an ability to modify the `AutoMinorVersionUpgrade` property of the
Replication Group (which is enabled by default) accordingly.

Signed-off-by: Krzysztof Wilczynski <krzysztof.wilczynski@linux.com>
@ghost
Copy link

ghost commented Apr 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants