openstack_networking_port_v2 allowed_address_pairs are sorted

[carlpett]

The allowed_address_pairs property is ordered by creation time in the state file, but the Gophercloud api returns them sorted, rather than the order which they were inserted. If they were not created in sorted order, Terraform wants to apply a change of order in every execution (since the output does not actually change after apply)

Terraform Version

Terraform v0.7.3

Affected Resource(s)

• openstack_networking_port_v2

Terraform Configuration Files

resource "openstack_networking_port_v2" "vrrp-ports" {
  count = 3
  name = "${var.vrrp-names[count.index]}"
  network_id = "${var.network_id}"
  admin_state_up = "true"
  fixed_ip {
    subnet_id = "${var.subnet_id}"
  }
}
resource "openstack_networking_port_v2" "instance-ports" {
  count = 2
  name = "instance-port-${count.index+1}"
  network_id = "${var.network_id}"
  admin_state_up = "true"
  fixed_ip {
    subnet_id = "${var.subnet_id}"
  }
  allowed_address_pairs {
    ip_address = "${openstack_networking_port_v2.my-ports.0.fixed_ip.0.ip_address}"
  }
  allowed_address_pairs {
    ip_address = "${openstack_networking_port_v2.my-ports.1.fixed_ip.0.ip_address}"
  }
  allowed_address_pairs {
    ip_address = "${openstack_networking_port_v2.my-ports.2.fixed_ip.0.ip_address}"
  }
}

Steps to Reproduce

If vrrp-ports gets addresses in a different ordering compared with their index in the state file, every apply will try to change the order of allowed_address_pairs:

1. terraform apply

openstack_networking_port_v2.instance-ports.1: Modifying...
  allowed_address_pairs.1.ip_address: "10.36.8.4" => "10.36.8.5"
  allowed_address_pairs.2.ip_address: "10.36.8.5" => "10.36.8.4"
openstack_networking_port_v2.instance-ports.0: Modifying...
  allowed_address_pairs.1.ip_address: "10.36.8.4" => "10.36.8.5"
  allowed_address_pairs.2.ip_address: "10.36.8.5" => "10.36.8.4"

1. terraform apply

openstack_networking_port_v2.instance-ports.1: Modifying...
  allowed_address_pairs.1.ip_address: "10.36.8.4" => "10.36.8.5"
  allowed_address_pairs.2.ip_address: "10.36.8.5" => "10.36.8.4"
openstack_networking_port_v2.instance-ports.0: Modifying...
  allowed_address_pairs.1.ip_address: "10.36.8.4" => "10.36.8.5"
  allowed_address_pairs.2.ip_address: "10.36.8.5" => "10.36.8.4"

1. terraform apply

openstack_networking_port_v2.instance-ports.1: Modifying...
  allowed_address_pairs.1.ip_address: "10.36.8.4" => "10.36.8.5"
  allowed_address_pairs.2.ip_address: "10.36.8.5" => "10.36.8.4"
openstack_networking_port_v2.instance-ports.0: Modifying...
  allowed_address_pairs.1.ip_address: "10.36.8.4" => "10.36.8.5"
  allowed_address_pairs.2.ip_address: "10.36.8.5" => "10.36.8.4"

The cause is that ports ip addresses are out of order:

$ terraform state show openstack_networking_port_v2.vrrp-ports[0]
[...]
fixed_ip.#              = 1
fixed_ip.0.ip_address   = 10.36.8.3
[...]

$ terraform state show openstack_networking_port_v2.vrrp-ports[1]
[...]
fixed_ip.#              = 1
fixed_ip.0.ip_address   = 10.36.8.5
[...]

$ terraform state show openstack_networking_port_v2.vrrp-ports[2]
[...]
fixed_ip.#              = 1
fixed_ip.0.ip_address   = 10.36.8.4
[...]

Could the allowed_address_pairs be stored in an unordered structure? Otherwise I guess it will require a bit more complicated logic for determining changes.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.