Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AWS Resource WAF SizeConstraintSet #9689

Merged

Conversation

sharmaansh21
Copy link
Contributor

➜  terraform git:(master) ✗ make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSWafSizeConstraintSet_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/10/28 20:42:18 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSWafSizeConstraintSet_ -timeout 120m
=== RUN   TestAccAWSWafSizeConstraintSet_basic
--- PASS: TestAccAWSWafSizeConstraintSet_basic (115.53s)
=== RUN   TestAccAWSWafSizeConstraintSet_changeNameForceNew
--- PASS: TestAccAWSWafSizeConstraintSet_changeNameForceNew (119.62s)
=== RUN   TestAccAWSWafSizeConstraintSet_disappears
--- PASS: TestAccAWSWafSizeConstraintSet_disappears (64.22s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    304.653s

/cc @stack72

If SizeConstraintSet is nill that means there is an error that is handled already :)

@stack72
Copy link
Contributor

stack72 commented Oct 28, 2016

LGTM! You are on fire today with the PRs @optimisticanshul :)

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSWafSizeConstraintSet_'                                                                                        ✹
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/10/28 23:56:23 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSWafSizeConstraintSet_ -timeout 120m
=== RUN   TestAccAWSWafSizeConstraintSet_basic
--- PASS: TestAccAWSWafSizeConstraintSet_basic (20.10s)
=== RUN   TestAccAWSWafSizeConstraintSet_changeNameForceNew
--- PASS: TestAccAWSWafSizeConstraintSet_changeNameForceNew (34.19s)
=== RUN   TestAccAWSWafSizeConstraintSet_disappears
--- PASS: TestAccAWSWafSizeConstraintSet_disappears (19.23s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    73.540s

@stack72 stack72 merged commit cc8f111 into hashicorp:master Oct 28, 2016
mathieuherbert pushed a commit to mathieuherbert/terraform that referenced this pull request Oct 30, 2016
gusmat pushed a commit to gusmat/terraform that referenced this pull request Dec 6, 2016
@ghost
Copy link

ghost commented Apr 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants