Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AWS Resource WAF SqlInjectionMatchSet #9709

Conversation

sharmaansh21
Copy link
Contributor

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSWafSqlInjectionMatchSet_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/10/29 08:30:37 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSWafSqlInjectionMatchSet_ -timeout 120m
=== RUN   TestAccAWSWafSqlInjectionMatchSet_basic
--- PASS: TestAccAWSWafSqlInjectionMatchSet_basic (98.83s)
=== RUN   TestAccAWSWafSqlInjectionMatchSet_changeNameForceNew
--- PASS: TestAccAWSWafSqlInjectionMatchSet_changeNameForceNew (147.69s)
=== RUN   TestAccAWSWafSqlInjectionMatchSet_disappears
--- PASS: TestAccAWSWafSqlInjectionMatchSet_disappears (85.38s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    337.190s

/cc @stack72

@stack72
Copy link
Contributor

stack72 commented Oct 31, 2016

@optimisticanshul can you rebase this? So many new resources have caused a conflict ;)

@stack72 stack72 added the waiting-response An issue/pull request is waiting for a response from the community label Oct 31, 2016
@sharmaansh21 sharmaansh21 force-pushed the aws-resource-waf-sql-injection-match-set branch from c3128d4 to 5047f49 Compare October 31, 2016 17:42
@sharmaansh21
Copy link
Contributor Author

@stack72 Rebased 👍

@stack72
Copy link
Contributor

stack72 commented Oct 31, 2016

LGTM! Thanks @optimisticanshul :)

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSWafSqlInjectionMatchSet_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/10/31 17:49:42 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSWafSqlInjectionMatchSet_ -timeout 120m
=== RUN   TestAccAWSWafSqlInjectionMatchSet_basic
--- PASS: TestAccAWSWafSqlInjectionMatchSet_basic (19.41s)
=== RUN   TestAccAWSWafSqlInjectionMatchSet_changeNameForceNew
--- PASS: TestAccAWSWafSqlInjectionMatchSet_changeNameForceNew (36.19s)
=== RUN   TestAccAWSWafSqlInjectionMatchSet_disappears
--- PASS: TestAccAWSWafSqlInjectionMatchSet_disappears (19.31s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    74.939s

All WAF resources now merged

@stack72 stack72 merged commit 6432bb5 into hashicorp:master Oct 31, 2016
@sharmaansh21 sharmaansh21 deleted the aws-resource-waf-sql-injection-match-set branch October 31, 2016 17:53
gusmat pushed a commit to gusmat/terraform that referenced this pull request Dec 6, 2016
@ghost
Copy link

ghost commented Apr 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement provider/aws waiting-response An issue/pull request is waiting for a response from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants