Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/openstack: Add 'value_specs' option to 'openstack_fw_rule_v1' resource #9834

Conversation

fatmcgav
Copy link
Contributor

@fatmcgav fatmcgav commented Nov 3, 2016

Refactor to use common 'types.go' and 'MapValueSpecs' function.
Website docs updated.

@fatmcgav
Copy link
Contributor Author

fatmcgav commented Nov 3, 2016

@jtopjian First of the value_spec additions to the openstack_fw_* resources :)

@fatmcgav fatmcgav changed the title provider/openstack: Add 'value_specs' option to 'openstack_fw_rule_v1… provider/openstack: Add 'value_specs' option to 'openstack_fw_rule_v1' resource Nov 3, 2016
@jtopjian
Copy link
Contributor

jtopjian commented Nov 4, 2016

@fatmcgav The logic for "any" protocol needs to be added to the ToRuleCreateMap function:

https://github.com/gophercloud/gophercloud/blob/master/openstack/networking/v2/extensions/fwaas/rules/requests.go#L113-L124

I wonder if there's a way to trigger the "parent" function rather than copying custom logic like this.

@fatmcgav
Copy link
Contributor Author

fatmcgav commented Nov 4, 2016

@jtopjian Ah, didn't spot that...

I'll get it added...
Calling the parent function would be nice, but I'd guess challenging, as I'm already doing a lot of the work in BuildRequest...

…' resource.

Refactor to use common 'types.go' and 'MapValueSpecs' function.
Website docs updated.
@fatmcgav fatmcgav force-pushed the openstack_firewall_rule_v1_add_value_specs branch from db1ce29 to e3246bc Compare November 4, 2016 07:20
@fatmcgav
Copy link
Contributor Author

fatmcgav commented Nov 4, 2016

@jtopjian OK, "any" protocol added to ToRuleCreateMap.

I've also checked the other openstack_fw resources, and there wasn't any others with custom CreateMap functionality... :)

@jtopjian jtopjian merged commit c3d6bdd into hashicorp:master Nov 4, 2016
@fatmcgav fatmcgav deleted the openstack_firewall_rule_v1_add_value_specs branch November 4, 2016 19:07
@ghost
Copy link

ghost commented Apr 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants