provider/aws: Redshift Cluster: Fix for master_username & password #9837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ninir
force-pushed
the
redshift_cluster_password
branch
2 times, most recently
from
01eff3e
to
ba9430a
Compare
Ninir
changed the title
Ninir
force-pushed
the
redshift_cluster_password
branch
from
ba9430a
to
e3a58cf
Compare
Ninir
force-pushed
the
redshift_cluster_password
branch
from
e3a58cf
to
f8a2292
Compare
Ninir
force-pushed
the
redshift_cluster_password
branch
from
f8a2292
to
b136790
Compare
Ninir
force-pushed
the
redshift_cluster_password
branch
from
b136790
to
c250c10
Compare
catsby
approved these changes
Dec 16, 2016
| * `master_password` - (Required) Password for the master DB user. Note that this may | ||
| show up in logs, and it will be stored in the state file. Password must contain at least 8 chars and | ||
| * `master_password` - (Required unless a `snapshot_identifier` is provided) Password for the master DB user. | ||
| Note that this may show up in logs, and it will be stored in the state file. Password must contain at least 8 chars and |
There was a problem hiding this comment.
master_password has Sensitive: true set, which should keep it's contents out of the logs. We should optionally pgp encrypt it in the state, like we been doing for some other resources
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This forces the
master_username&master_passwordto be defined when not in a restore mode.If
snapshot_identifieris not set by the user, those are required. Currently, AWS returns errors about those being not set.