Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AWS Redshift Enhanced VPC Routing #9950

Conversation

sharmaansh21
Copy link
Contributor

Adds #9928

anssharma@Ban-1Anssharma-M:~/Code/go/src/github.com/hashicorp/terraform|master⚡
⇒  make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/11/08 17:24:16 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled -timeout 120m
=== RUN   TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled
--- PASS: TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled (672.42s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	677.841s

/cc @stack72 @paddyforan

@stack72
Copy link
Contributor

stack72 commented Nov 8, 2016

Hi @optimisticanshul

Thanks for the work here - it seems that the parameter isn't being used in the Update func - is it not updatable? Also, the documentation will also need to be updated

Thanks :)

P.

@sharmaansh21
Copy link
Contributor Author

anssharma@Ban-1Anssharma-M:~/Code/go/src/github.com/hashicorp/terraform|9928-aws-redshift-enhanced-vpc-routing⚡
⇒  make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/11/08 17:52:22 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled -timeout 120m
=== RUN   TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled
--- PASS: TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled (944.52s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    949.855s

@stack72 Ready for another review.

Copy link
Contributor

@paddycarver paddycarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for the contribution!

@paddycarver paddycarver merged commit 78f8fea into hashicorp:master Nov 8, 2016
@ghost
Copy link

ghost commented Apr 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants