Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: Update github.com/gophercloud/gophercloud #9966

Merged

Conversation

fatmcgav
Copy link
Contributor

@fatmcgav fatmcgav commented Nov 8, 2016

Fix issue with double base64 encoding userdata value.
Fixes #9965

Fix issue with double base64 encoding userdata value
@fatmcgav
Copy link
Contributor Author

fatmcgav commented Nov 8, 2016

@jtopjian Nice easy one... ;)

@jtopjian jtopjian merged commit cfa4d9b into hashicorp:master Nov 9, 2016
@fatmcgav
Copy link
Contributor Author

fatmcgav commented Nov 9, 2016

@jtopjian Are you able to cherry pick this one onto maint-0.7 branch?
As otherwise looks like it won't land until 0.8.0 release...

@jtopjian
Copy link
Contributor

jtopjian commented Nov 9, 2016

@fatmcgav I've marked the change under the 0.7.10 header. Whoever does the maint release should be handling that.

@jtopjian
Copy link
Contributor

jtopjian commented Nov 9, 2016

@fatmcgav Ah, actually I just read the instructions on this. I'll cherry pick this as soon as I can.

@jtopjian
Copy link
Contributor

jtopjian commented Nov 9, 2016

@fatmcgav There was a 0.7.10 release cut today. I didn't get to cherry pick the commit in time. Sorry about that! I'll get it done ASAP and it'll be in the next release.

@fatmcgav
Copy link
Contributor Author

fatmcgav commented Nov 9, 2016

@jtopjian They're not hanging around with 0.7 releases are they... ;) Much appreciated...

Edit: So it looks like whatever they use to update the CHANGELOG as part of release has removed the 'Improvement' line for this one... From both the 0.7.10 release AND from master Changelog...

@jtopjian
Copy link
Contributor

@fatmcgav OK, this is all sorted out. I'm really sorry about that. This change will be in the next 0.7 release as well as 0.8.

@fatmcgav
Copy link
Contributor Author

No worries, cheers for the assist.

Gav

On 10 Nov 2016 16:06, "Joe Topjian" notifications@github.com wrote:

@fatmcgav https://github.com/fatmcgav OK, this is all sorted out. I'm
really sorry about that. This change will be in the next 0.7 release as
well as 0.8.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#9966 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACIbItHUU0nYUNqtyNGr-SdQvh10ckKoks5q80DngaJpZM4KsznP
.

@ghost
Copy link

ghost commented Apr 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provider/openstack: openstack_compute_instance_v2 'user_data' gets double encoded
2 participants