Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Use helper methods for checking partition #14319

Merged
merged 2 commits into from
May 9, 2017

Conversation

grubernaut
Copy link
Contributor

@grubernaut grubernaut commented May 9, 2017

Related: #12414

@grubernaut grubernaut requested a review from stack72 May 9, 2017 16:18
Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to reverse the change :)

@@ -109,7 +109,7 @@ func resourceAwsCloudWatchLogGroupRead(d *schema.ResourceData, meta interface{})
d.Set("retention_in_days", lg.RetentionInDays)
}

if meta.(*AWSClient).partition != "aws-us-gov" {
if meta.(*AWSClient).IsChinaCloud() || meta.(*AWSClient).IsGovCloud() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be if !IsChina || !IsGovCloud

Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merge when ready :)

@grubernaut grubernaut merged commit 4677aca into master May 9, 2017
@grubernaut grubernaut deleted the f-update-partition-check branch May 9, 2017 16:30
@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants