Implement aws_db_subnet_group resource #164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| stateConf := &resource.StateChangeConf{ | ||
| // TODO are there any other states? | ||
| Pending: []string{}, |
There was a problem hiding this comment.
Yes, I imagine this won't work as is, due to this. If we run the acceptance tests it should give us the various states. Are you familiar with how to run those?
There was a problem hiding this comment.
Yes, but they all pass - the DB subnet group is created so quickly that I can't issue a request fast enough to discover its intermediate state. The docs and a fair amount of googling have turned up no answers, but we have an AWS enterprise support account; I'll ask them. In the meantime, can this be merged, as the lack of intermediate states is fine in practice?
alekstorm
force-pushed
the
aws-db-subnet-group
branch
from
d28da4b to
0b9fd66
Compare
|
Hey @alekstorm, before we got this in we saw #295 using the new schema API, which is preferable. Thanks for all your help! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on mitchellh/goamz#74. Related to #28.
Also adds a
db_subnet_group_nameparameter toaws_db_instance.I'm new to Go, and mostly fumbled my way through this PR by copying and adapting
aws_db_security_group; sorry if I screwed up any idioms.