-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/archive: Implementing archive provider #7322
Conversation
👍 this will make it so much easier to work with |
9908c19
to
b5dc1a5
Compare
143ecec
to
910ac03
Compare
So i've been testing this for a while now with lambda and it works well - i am going to merge it :) I believe it's a simple and effective way of getting going Thanks @BSick7 |
|
NOTE: One of `source_content_filename` (with `source_content`), `source_file`, or `source_dir` must be specified. | ||
|
||
* `type` - (required) The type of archive to generate. | ||
NOTE: `archive` is supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should say zip
, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good find! I guess I was a little aggressive when I renamed zip
to archive
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I have missed something, but how does it track, that source_file was changed? I didn't find anything similar to source_code_hash of aws_lambda_function. |
Hey all! Please take note of #9924, which implements a base_archive argument so you can keep all the dependencies of the lambda function in an archive and add individual files to that instead of cluttering the directory tree (and your repository) Let me know if there is anything i can do to increase the chances of this ending up in terraform. I'm planning to release a module that makes use of this. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Purpose
This introduces a provider to generate archive files from content, a file, or a directory of files.
The original impetus for this is the ability to package lambda functions on-the-fly without the need for specific zip utilities packaged in your repo.
This PR only includes support for zip files.
Checklist