provider/atlas: Add a Atlas Artifact Data Source

[catsby]

This adds a Data Source for Atlas Artifacts. It's a copy-paste-tweak of the existing atlas_artifact resource, which itself acts like a Data Source, but implemented before we had true Data Sources. I've marked atlas_artifacts as deprecated in the documentation and in the code.

[phinze]

Looks great! I assume those new acctests are passing happily? If so LTGM

[catsby]

Indeed, thanks for asking

TF_ACC=1 go test ./builtin/providers/atlas -v -run=TestAccDataSourceArtifact_ -timeout 120m
=== RUN   TestAccDataSourceArtifact_basic
--- PASS: TestAccDataSourceArtifact_basic (2.39s)
=== RUN   TestAccDataSourceArtifact_metadata
--- PASS: TestAccDataSourceArtifact_metadata (2.27s)
=== RUN   TestAccDataSourceArtifact_metadataSet
--- PASS: TestAccDataSourceArtifact_metadataSet (2.32s)
=== RUN   TestAccDataSourceArtifact_buildLatest
--- PASS: TestAccDataSourceArtifact_buildLatest (2.30s)
=== RUN   TestAccDataSourceArtifact_versionAny
--- PASS: TestAccDataSourceArtifact_versionAny (2.24s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/atlas  11.521s

[apparentlymart]

Assuming the new data source has a compatible interface to the old resource, we have a function to provide the legacy resource in terms of the data source code so it doesn't need to be duplicated. The terraform_remote_state resource is an example of that.

Not a huge deal either way but just wanted to let you know that there's another way to achieve this.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.