Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS] Retry AttachInternetGateway and increase timeout #7891

Merged
merged 1 commit into from
Aug 8, 2016

Conversation

carlossg
Copy link
Contributor

@carlossg carlossg commented Aug 1, 2016

We've seen cases where it fails due to AWS eventual consistency

@jen20
Copy link
Contributor

jen20 commented Aug 3, 2016

Hi @carlossg! I have personally seen this issue - however I think it would be best for either @catsby or @stack72 to review this since they have more context here.

@stack72
Copy link
Contributor

stack72 commented Aug 8, 2016

This seems like a sane change :) The tests look good as well!

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSInternetGateway_'                                          ✹
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/08 13:10:31 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSInternetGateway_ -timeout 120m
=== RUN   TestAccAWSInternetGateway_importBasic
--- PASS: TestAccAWSInternetGateway_importBasic (60.60s)
=== RUN   TestAccAWSInternetGateway_basic
--- PASS: TestAccAWSInternetGateway_basic (107.23s)
=== RUN   TestAccAWSInternetGateway_delete
--- PASS: TestAccAWSInternetGateway_delete (85.25s)
=== RUN   TestAccAWSInternetGateway_tags
--- PASS: TestAccAWSInternetGateway_tags (89.44s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    342.546s

@stack72 stack72 merged commit e3b7760 into hashicorp:master Aug 8, 2016
@carlossg carlossg deleted the retry-igw branch August 8, 2016 08:12
@ghost
Copy link

ghost commented Apr 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants