provider/aws: Add aws_default_route_table resource #8323
Conversation
| // revoke all default and pre-existing routes on the default route table. | ||
| // In the UPDATE method, we'll apply only the rules in the configuration. | ||
| log.Printf("[DEBUG] Revoking default routes for Default Route Table for %s", d.Id()) | ||
| if err := revokeAllRouteTableRules(d.Id(), meta); err != nil { |
There was a problem hiding this comment.
Is there a potentially for this to cause issues if the revoke happens and the update fails?
There was a problem hiding this comment.
We want to revoke the rules regardless if there is any update to be made. The procedure is that during "creation" we wipe the slate clean. This is documented to warn people .
|
Few small things but this is really good - loved the note about being wary! I can forsee people getting themselves into trouble here so it's good to point this out in advance |
|
The PR looks good to me - the questions were based more on my misunderstanding of how it would work. Explanations and the documentation help to clear this up LGTM :) |
* provider/aws: Add docs for Default Route Table * add new default_route_table_id attribute, test to VPC * stub * add warning to docs * rough implementation * first test * update test, add swap test * fix typo
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Adds a resource to manage the default route table that comes with every VPC.
This is an advanced resource with caveats mentioned in the documentation.
Part of #6093