provider/aws: Add JSON validation to the aws_cloudwatch_event_rule resource.

[kwilczynski]

This commit adds support for new helper function which is used to
normalise and validate JSON string. Also adds new validation function
to wrap around the aforementioned helper.

Signed-off-by: Krzysztof Wilczynski krzysztof.wilczynski@linux.com

[kwilczynski]

Part of work which began in #8028.

[kwilczynski]

Tests are passing:

(unit)

$ make test TEST=./builtin/providers/aws TESTARGS='-v -run=TestResourceAWSCloudWatchEventRule_validateEventPatternValue'
==> Checking that code complies with gofmt requirements...
==> Checking AWS provider for unchecked errors...
==> NOTE: at this time we only look for uncheck errors in the AWS package
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/09/14 22:40:23 Generated command/internal_plugin_list.go
TF_ACC= go test ./builtin/providers/aws -v -run=TestResourceAWSCloudWatchEventRule_validateEventPatternValue -timeout=30s -parallel=4
=== RUN   TestResourceAWSCloudWatchEventRule_validateEventPatternValue
--- PASS: TestResourceAWSCloudWatchEventRule_validateEventPatternValue (0.00s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    0.021s

(acceptance)

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSCloudWatchEventRule'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/09/14 19:36:21 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSCloudWatchEventRule -timeout 120m
=== RUN   TestAccAWSCloudWatchEventRule_importBasic
--- PASS: TestAccAWSCloudWatchEventRule_importBasic (15.01s)
=== RUN   TestAccAWSCloudWatchEventRule_basic
--- PASS: TestAccAWSCloudWatchEventRule_basic (25.89s)
=== RUN   TestAccAWSCloudWatchEventRule_full
--- PASS: TestAccAWSCloudWatchEventRule_full (15.08s)
=== RUN   TestAccAWSCloudWatchEventRule_enable
--- PASS: TestAccAWSCloudWatchEventRule_enable (37.42s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    93.441s

[radeksimko]

We send the minified (normalized) JSON to the API which is the one that is limited to 2048 characters, not the original JSON string with spaces, newlines etc.

At this point we would prevent the user from sending minified JSON to the API which can be below 2048 chars after stripping whitespaces etc. Also I'm not sure if there is any point in checking length of invalid JSON.

It may be worth covering this particular edge case by a test.

[radeksimko]

I'm happy to merge this once the mentioned edge case w/ normalization & length check is addressed - this otherwise looks good.

[kwilczynski]

@radeksimko ah, that is a very good point! I will fix this right away.

[kwilczynski]

Unit test is passing:

$ make test TEST=./builtin/providers/aws TESTARGS='-v -run=TestResourceAWSCloudWatchEventRule_validateEventPatternValue'
==> Checking that code complies with gofmt requirements...
==> Checking AWS provider for unchecked errors...
==> NOTE: at this time we only look for uncheck errors in the AWS package
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/09/18 15:05:26 Generated command/internal_plugin_list.go
TF_ACC= go test ./builtin/providers/aws -v -run=TestResourceAWSCloudWatchEventRule_validateEventPatternValue -timeout=30s -parallel=4
=== RUN   TestResourceAWSCloudWatchEventRule_validateEventPatternValue
--- PASS: TestResourceAWSCloudWatchEventRule_validateEventPatternValue (0.00s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    0.015s

[kwilczynski]

@radeksimko I have updated the ValidateFunc, it should do the right thing now. Thank you!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.